Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8962

Set darktime in makeRawVisitInfo

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      lsst.afw.image.makeRawVisitInfo does not set the darktime. At the least, it should default to the exposure time.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            I doubt that the base class should do this. Instances of the base class certainly should do it, and the base class should make it as easy as possible, but the base class was explicitly written with the philosophy "when in doubt, refuse to guess".

            Show
            rowen Russell Owen added a comment - I doubt that the base class should do this. Instances of the base class certainly should do it, and the base class should make it as easy as possible, but the base class was explicitly written with the philosophy "when in doubt, refuse to guess".
            Hide
            price Paul Price added a comment -

            I think that's a fine philosophy for most things, but for the darktime there's a very reasonable default that I think every camera would want to use and so it should be in the base class.

            Show
            price Paul Price added a comment - I think that's a fine philosophy for most things, but for the darktime there's a very reasonable default that I think every camera would want to use and so it should be in the base class.
            Hide
            price Paul Price added a comment -

            Russell Owen, would you review this please?

            price@price-laptop:~/LSST/obs/base (tickets/DM-8962=) $ git sub
            commit 26beb3c88b2044d83c5dabeb618fc48581431b42
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Tue Jan 10 13:59:15 2017 -0500
             
                MakeRawVisitInfo: set darkTime
                
                To DARKTIME if it exists, or the exposure time if not.
             
             python/lsst/obs/base/makeRawVisitInfo.py | 2 ++
             tests/testMakeRawVisitInfo.py            | 5 +++++
             2 files changed, 7 insertions(+)
             
            commit 0649aaaec13c73d7dcfd06208057873f4d03fa0d
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Tue Jan 10 14:33:41 2017 -0500
             
                makeRawVisitInfo: fix typo in warning message
             
             python/lsst/obs/base/makeRawVisitInfo.py | 2 +-
             1 file changed, 1 insertion(+), 1 deletion(-)
            

            Show
            price Paul Price added a comment - Russell Owen , would you review this please? price@price-laptop:~/LSST/obs/base (tickets/DM-8962=) $ git sub commit 26beb3c88b2044d83c5dabeb618fc48581431b42 Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 10 13:59:15 2017 -0500   MakeRawVisitInfo: set darkTime To DARKTIME if it exists, or the exposure time if not.   python/lsst/obs/base/makeRawVisitInfo.py | 2 ++ tests/testMakeRawVisitInfo.py | 5 +++++ 2 files changed, 7 insertions(+)   commit 0649aaaec13c73d7dcfd06208057873f4d03fa0d Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 10 14:33:41 2017 -0500   makeRawVisitInfo: fix typo in warning message   python/lsst/obs/base/makeRawVisitInfo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
            Hide
            rowen Russell Owen added a comment -

            I really do believe that looking for "DARKTIME" and falling back to "EXPTIME" is not reasonable behavior for the base class. If you insist on going that route please file an RFC so we can have a wider discussion.

            On the other hand, if you are willing to just look for DARKTIME then i am very much in favor of that enhancement.

            Show
            rowen Russell Owen added a comment - I really do believe that looking for "DARKTIME" and falling back to "EXPTIME" is not reasonable behavior for the base class. If you insist on going that route please file an RFC so we can have a wider discussion. On the other hand, if you are willing to just look for DARKTIME then i am very much in favor of that enhancement.
            Hide
            price Paul Price added a comment -

            OK. RFC-274 solicits further opinions and arguments.

            Show
            price Paul Price added a comment - OK. RFC-274 solicits further opinions and arguments.
            Hide
            price Paul Price added a comment -

            Abandoning following withdrawal of RFC-274. For a different fix, see DM-9004.

            Show
            price Paul Price added a comment - Abandoning following withdrawal of RFC-274 . For a different fix, see DM-9004 .

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Russell Owen
                Watchers:
                John Parejko, Paul Price, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel