Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8972

obs_cfht table file uses envAppend

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_cfht
    • Labels:
      None

      Description

      obs_cfht.table includes:

      envAppend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
      envAppend(PYTHONPATH, ${PRODUCT_DIR}/python)
      envAppend(PATH, ${PRODUCT_DIR}/bin)
      

      These envAppend calls should be envPrepend.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Dominique Boutigny, are you comfortable reviewing this? I think it's straightforward.

          price@price-laptop:~/LSST/obs/cfht (tickets/DM-8972=) $ git sub-patch
          commit f17453cc83e06b3390e7f4a2bc1e12ecc2897679
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Jan 11 13:16:23 2017 -0500
           
              ups: prepend to environment instead of append
              
              Prepending ensures that a newly 'setup' package overrides
              the system defaults.
           
          diff --git a/ups/obs_cfht.table b/ups/obs_cfht.table
          index 22a9b16..69d2512 100644
          --- a/ups/obs_cfht.table
          +++ b/ups/obs_cfht.table
          @@ -5,6 +5,6 @@ setupRequired(pipe_tasks)
           
           setupOptional(testdata_cfht)
           envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
          -envAppend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
          -envAppend(PYTHONPATH, ${PRODUCT_DIR}/python)
          -envAppend(PATH, ${PRODUCT_DIR}/bin)
          +envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
          +envPrepend(PYTHONPATH, ${PRODUCT_DIR}/python)
          +envPrepend(PATH, ${PRODUCT_DIR}/bin)
          

          Show
          price Paul Price added a comment - Dominique Boutigny , are you comfortable reviewing this? I think it's straightforward. price@price-laptop:~/LSST/obs/cfht (tickets/DM-8972=) $ git sub-patch commit f17453cc83e06b3390e7f4a2bc1e12ecc2897679 Author: Paul Price <price@astro.princeton.edu> Date: Wed Jan 11 13:16:23 2017 -0500   ups: prepend to environment instead of append Prepending ensures that a newly 'setup' package overrides the system defaults.   diff --git a/ups/obs_cfht.table b/ups/obs_cfht.table index 22a9b16..69d2512 100644 --- a/ups/obs_cfht.table +++ b/ups/obs_cfht.table @@ -5,6 +5,6 @@ setupRequired(pipe_tasks) setupOptional(testdata_cfht) envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) -envAppend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) -envAppend(PYTHONPATH, ${PRODUCT_DIR}/python) -envAppend(PATH, ${PRODUCT_DIR}/bin) +envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) +envPrepend(PYTHONPATH, ${PRODUCT_DIR}/python) +envPrepend(PATH, ${PRODUCT_DIR}/bin)
          Hide
          boutigny Dominique Boutigny added a comment -

          I do not see any problem with this change --> Merge

          Show
          boutigny Dominique Boutigny added a comment - I do not see any problem with this change --> Merge
          Hide
          price Paul Price added a comment -

          Thanks Dominique Boutigny!

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Dominique Boutigny ! Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Dominique Boutigny
              Watchers:
              Dominique Boutigny, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel