Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:DRP S17-2
-
Team:Data Release Production
Description
The ordinates for the overscan spline interpolation can violate the requirement of monotonic increasing in the presence of masked rows, causing GSL to reject it and we end up raising an exception. For example (notice the third element):
#1 0x00002aaadf6ccae4 in lsst::afw::math::InterpolateGsl::InterpolateGsl (
|
this=0x6f4ef0, x=std::vector of length 30, capacity 32 = {...},
|
y=std::vector of length 30, capacity 32 = {...},
|
style=lsst::afw::math::Interpolate::AKIMA_SPLINE)
|
at src/math/Interpolate.cc:211
|
211 int const status = ::gsl_interp_init(_interp, &x[0], &y[0], _y.size());
|
(gdb) p x
|
$19 = std::vector of length 30, capacity 32 = {-4.6668978729026289,
|
-1.0006934865900383, -2.2712418300653598, -0.76676245210727956,
|
-0.70019157088122619, -0.63362068965517238, -0.5668103448275863, -0.5,
|
-0.43342911877394619, -0.36685823754789276, -0.30028735632183906,
|
-0.23371647509578544, -0.1669061302681992, -0.10009578544061301,
|
-0.033524904214559385, 0.033045977011494247, 0.099616858237547928,
|
0.16618773946360157, 0.23299808429118776, 0.29980842911877403,
|
0.36637931034482762, 0.43295019157088127, 0.49952107279693497,
|
0.56609195402298851, 0.6329022988505747, 0.69971264367816088,
|
0.7662835249042147, 0.83285440613026807, 0.89942528735632199,
|
0.96623563218390807}
|
This is because the code to generate these ordinates (binning the overscan data vector) is incorrect.
Attachments
Activity
Paul Price
created issue -
Paul Price
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Reviewers | Lauren MacArthur [ lauren ] | |
| Status | To Do [ 10001 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Paul Price
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Epic Link |
|
| Sprint | DRP S17-2 [ 356 ] |