Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_simpleShape
-
Labels:None
-
Story Points:0.5
-
Team:Data Release Production
Description
simpleShape can be verbose due to throwing pex::exceptions::RuntimeError. Throwing meas::base::MeasurementError would make it quieter.
Attachments
Activity
The code changes look straightforward, and the commit history is clear and concise. I'm just running a few tests and then will mark this as Reviewed.
Looks good as it is, I don't see any need for changes.
Thanks, Ian.
Merged to master.
Paul Price
added a comment - Thanks, Ian.
Merged to master. 
Ian Sullivan, would you review this, please?
pprice@tiger-sumire:/tigress/pprice/focusSweeps/meas_extensions_simpleShape (tickets/DM-9011=) $ git subcommit 93df049d84e56060b53fe0b277e442f65a701076Author: Paul Price <price@astro.princeton.edu>Date: Tue Jan 17 14:14:04 2017 -0500quiet errors by using MeasurementErrorThe measurement framework traps this error and uses it to seta flag. The RuntimeError isn't recognised and therefore resultsin messages printed.src/simpleShape.cc | 16 +++++++++-------1 file changed, 9 insertions(+), 7 deletions(-)commit 71048f04ca454adb34320b62a477f7300cdffa1eAuthor: Paul Price <price@astro.princeton.edu>Date: Tue Jan 17 14:16:08 2017 -0500git: ignore generated docs.gitignore | 1 +1 file changed, 1 insertion(+)