Details

    • Templates:
    • Story Points:
      0.5
    • Team:
      Data Release Production

      Description

      simpleShape can be verbose due to throwing pex::exceptions::RuntimeError. Throwing meas::base::MeasurementError would make it quieter.

        Activity

        Hide
        price Paul Price added a comment -

        Ian Sullivan, would you review this, please?

        pprice@tiger-sumire:/tigress/pprice/focusSweeps/meas_extensions_simpleShape (tickets/DM-9011=) $ git sub
        commit 93df049d84e56060b53fe0b277e442f65a701076
        Author: Paul Price <price@astro.princeton.edu>
        Date:   Tue Jan 17 14:14:04 2017 -0500
         
            quiet errors by using MeasurementError
            
            The measurement framework traps this error and uses it to set
            a flag. The RuntimeError isn't recognised and therefore results
            in messages printed.
         
         src/simpleShape.cc | 16 +++++++++-------
         1 file changed, 9 insertions(+), 7 deletions(-)
         
        commit 71048f04ca454adb34320b62a477f7300cdffa1e
        Author: Paul Price <price@astro.princeton.edu>
        Date:   Tue Jan 17 14:16:08 2017 -0500
         
            git: ignore generated docs
         
         .gitignore | 1 +
         1 file changed, 1 insertion(+)
        

        Show
        price Paul Price added a comment - Ian Sullivan , would you review this, please? pprice@tiger-sumire:/tigress/pprice/focusSweeps/meas_extensions_simpleShape (tickets/DM-9011=) $ git sub commit 93df049d84e56060b53fe0b277e442f65a701076 Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 17 14:14:04 2017 -0500   quiet errors by using MeasurementError The measurement framework traps this error and uses it to set a flag. The RuntimeError isn't recognised and therefore results in messages printed.   src/simpleShape.cc | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)   commit 71048f04ca454adb34320b62a477f7300cdffa1e Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 17 14:16:08 2017 -0500   git: ignore generated docs   .gitignore | 1 + 1 file changed, 1 insertion(+)
        Hide
        sullivan Ian Sullivan added a comment -

        The code changes look straightforward, and the commit history is clear and concise. I'm just running a few tests and then will mark this as Reviewed.

        Show
        sullivan Ian Sullivan added a comment - The code changes look straightforward, and the commit history is clear and concise. I'm just running a few tests and then will mark this as Reviewed.
        Hide
        sullivan Ian Sullivan added a comment -

        Looks good as it is, I don't see any need for changes.

        Show
        sullivan Ian Sullivan added a comment - Looks good as it is, I don't see any need for changes.
        Hide
        price Paul Price added a comment -

        Thanks, Ian.

        Merged to master.

        Show
        price Paul Price added a comment - Thanks, Ian. Merged to master.

          People

          • Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Ian Sullivan
            Watchers:
            Ian Sullivan, Paul Price
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development