Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9011

Make simpleShape less chatty

    XMLWordPrintable

Details

    • 0.5
    • Data Release Production

    Description

      simpleShape can be verbose due to throwing pex::exceptions::RuntimeError. Throwing meas::base::MeasurementError would make it quieter.

      Attachments

        Activity

          price Paul Price added a comment -

          sullivan, would you review this, please?

          pprice@tiger-sumire:/tigress/pprice/focusSweeps/meas_extensions_simpleShape (tickets/DM-9011=) $ git sub
          commit 93df049d84e56060b53fe0b277e442f65a701076
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Tue Jan 17 14:14:04 2017 -0500
           
              quiet errors by using MeasurementError
              
              The measurement framework traps this error and uses it to set
              a flag. The RuntimeError isn't recognised and therefore results
              in messages printed.
           
           src/simpleShape.cc | 16 +++++++++-------
           1 file changed, 9 insertions(+), 7 deletions(-)
           
          commit 71048f04ca454adb34320b62a477f7300cdffa1e
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Tue Jan 17 14:16:08 2017 -0500
           
              git: ignore generated docs
           
           .gitignore | 1 +
           1 file changed, 1 insertion(+)
          

          price Paul Price added a comment - sullivan , would you review this, please? pprice@tiger-sumire:/tigress/pprice/focusSweeps/meas_extensions_simpleShape (tickets/DM-9011=) $ git sub commit 93df049d84e56060b53fe0b277e442f65a701076 Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 17 14:14:04 2017 -0500   quiet errors by using MeasurementError The measurement framework traps this error and uses it to set a flag. The RuntimeError isn't recognised and therefore results in messages printed.   src/simpleShape.cc | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)   commit 71048f04ca454adb34320b62a477f7300cdffa1e Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 17 14:16:08 2017 -0500   git: ignore generated docs   .gitignore | 1 + 1 file changed, 1 insertion(+)

          The code changes look straightforward, and the commit history is clear and concise. I'm just running a few tests and then will mark this as Reviewed.

          sullivan Ian Sullivan added a comment - The code changes look straightforward, and the commit history is clear and concise. I'm just running a few tests and then will mark this as Reviewed.

          Looks good as it is, I don't see any need for changes.

          sullivan Ian Sullivan added a comment - Looks good as it is, I don't see any need for changes.
          price Paul Price added a comment -

          Thanks, Ian.

          Merged to master.

          price Paul Price added a comment - Thanks, Ian. Merged to master.

          People

            price Paul Price
            price Paul Price
            Ian Sullivan
            Ian Sullivan, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.