Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9016

Drivers should be able to be made less verbose about eups

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ctrl_pool
    • Templates:
    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      singleFrameDriver.py (and likely other pipe_drivers scripts) echos a bunch of eups commands and their output on startup. Those commands aren't part of the standard logging system and it should be possible to turn them on/off with an argument. I suggest either:

      • --verbose-eups-dump to turn them on
        or
      • --quiet-eups-dump to turn them off.

      I'm not sure whether on or off is the better default, and I'd be happy with either.

      One can turn them off currently via --batch-type none, but that changes the actual type of processing, which is not desired.

        Activity

        Hide
        price Paul Price added a comment -

        John Parejko, would you please give this a test and review? The command-line argument you want is --batch-verbose (selected because it corresponds with other arguments used for the batch system).

        price@price-laptop:~/LSST/ctrl/pool (tickets/DM-9016=) $ git sub
        commit 3b9e6cd096b583c68e0a671190d63462fceb176e
        Author: Paul Price <price@astro.princeton.edu>
        Date:   Tue Jan 17 18:14:21 2017 -0500
         
            Batch: add flag to control verbosity in batch script
            
            This can be triggered with the "--batch-verbose" command-line
            argument from the BatchArgumentParser. The default is now to
            have minimal verbosity in the batch script.
         
         python/lsst/ctrl/pool/parallel.py | 40 ++++++++++++++++++++++++---------------
         1 file changed, 25 insertions(+), 15 deletions(-)
        

        Show
        price Paul Price added a comment - John Parejko , would you please give this a test and review? The command-line argument you want is --batch-verbose (selected because it corresponds with other arguments used for the batch system). price@price-laptop:~/LSST/ctrl/pool (tickets/DM-9016=) $ git sub commit 3b9e6cd096b583c68e0a671190d63462fceb176e Author: Paul Price <price@astro.princeton.edu> Date: Tue Jan 17 18:14:21 2017 -0500   Batch: add flag to control verbosity in batch script This can be triggered with the "--batch-verbose" command-line argument from the BatchArgumentParser. The default is now to have minimal verbosity in the batch script.   python/lsst/ctrl/pool/parallel.py | 40 ++++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 15 deletions(-)
        Hide
        Parejkoj John Parejko added a comment -

        Thanks for taking care of this so quickly, and sorry for the delay reviewing it.

        Tested, and it does the job. Code looks fine, though maybe expand on the help string for the cmdline arg? Maybe: "Enable verbose output in batch script, including system environment information at batch start."

        Show
        Parejkoj John Parejko added a comment - Thanks for taking care of this so quickly, and sorry for the delay reviewing it. Tested, and it does the job. Code looks fine, though maybe expand on the help string for the cmdline arg? Maybe: "Enable verbose output in batch script, including system environment information at batch start."
        Hide
        price Paul Price added a comment -

        Thanks John.

        Updated the help string and merged to master.

        Show
        price Paul Price added a comment - Thanks John. Updated the help string and merged to master.

          People

          • Assignee:
            price Paul Price
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            John Parejko
            Watchers:
            John Parejko, Paul Price, Simon Krughoff, Yusra AlSayyad
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development