Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-903

SourceDetectionTask should only add flags.negative if config.thresholdParity == "both"

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP S17-3
    • Team:
      Data Release Production

      Description

      The SourceDetectionTask always adds "flags.negative" to the schema (if provided) but it is only used if config.thresholdParity == "both".

      As adding a field to a schema requires that the table passed to the run method have that field this is a significant nuisance when reusing the task. Please change the code to only modify the schema if it's going to set it.

        Attachments

          Issue Links

            Activity

            rhl Robert Lupton created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Team Princeton [ 10301 ]
            jbosch Jim Bosch made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ]
            jbosch Jim Bosch made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Epic Link DM-1739 [ 15553 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4 [ 120 ] Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Epic Link DM-1739 [ 15553 ] DM-2044 [ 16177 ]
            swinbank John Swinbank made changes -
            Epic Link DM-2044 [ 16177 ] DM-1910 [ 15942 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-W15-5 [ 120, 129 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, Science Pipelines DM-S15-2 [ 120, 140, 151 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ]
            swinbank John Swinbank made changes -
            Epic Link DM-1910 [ 15942 ]
            swinbank John Swinbank made changes -
            Issue Type Story [ 10001 ] Improvement [ 4 ]
            swinbank John Swinbank made changes -
            Rank Ranked lower
            swinbank John Swinbank made changes -
            Epic Link DM-5346 [ 23141 ]
            swinbank John Swinbank made changes -
            Assignee Robert Lupton [ rhl ]
            swinbank John Swinbank made changes -
            Assignee Lauren MacArthur [ lauren ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP X16-3 [ 120, 140, 217 ]
            swinbank John Swinbank made changes -
            Epic Link DM-5346 [ 23141 ] DM-6171 [ 24684 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP X16-3 [ 120, 140, 217 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ]
            swinbank John Swinbank made changes -
            Epic Link DM-6171 [ 24684 ] DM-8136 [ 27591 ]
            swinbank John Swinbank made changes -
            Epic Link DM-8136 [ 27591 ] DM-8306 [ 27828 ]
            swinbank John Swinbank made changes -
            Assignee Lauren MacArthur [ lauren ] Perry Gee [ pgee ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1 [ 120, 140 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP S17-2 [ 120, 140, 356 ]
            pgee Perry Gee made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP S17-2 [ 120, 140, 356 ] Science Pipelines DM-W15-4, Science Pipelines DM-S15-1, DRP S17-3 [ 120, 140, 360 ]
            pgee Perry Gee made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            pgee Perry Gee made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggering DM-9591 [ DM-9591 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-9849 [ DM-9849 ]

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                rhl Robert Lupton
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, John Swinbank, Perry Gee, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel