Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9041

Make indexed reference loader agnostic to ingest name

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production S17 - 1
    • Team:
      Alert Production

      Description

      The indexed reference loader reads the dataset name out of the ingest config, but that's ridiculous because you need to give it the dataset name to find the config. I'm removing the bit that loads the config and gets the name out of it, so that the loader will be agnostic to what name it was called at ingest time.

        Attachments

          Activity

          Hide
          krughoff Simon Krughoff added a comment -

          I'm giving this to you, but I can give it to someone else if you want. It's one line.

          Show
          krughoff Simon Krughoff added a comment - I'm giving this to you, but I can give it to someone else if you want. It's one line.
          Hide
          krughoff Simon Krughoff added a comment -

          It passed Jenkins and I tried it out with catalogs using different names.

          Show
          krughoff Simon Krughoff added a comment - It passed Jenkins and I tried it out with catalogs using different names.
          Hide
          krughoff Simon Krughoff added a comment -

          FYI, I just added one more commit with a simple test to show that providing a name not used for ingestions works.

          Show
          krughoff Simon Krughoff added a comment - FYI, I just added one more commit with a simple test to show that providing a name not used for ingestions works.
          Hide
          price Paul Price added a comment -

          Great! I made a couple of minor comments on the GitHub PR.
          Could you please fix the e-mail address in the second commit?

          Show
          price Paul Price added a comment - Great! I made a couple of minor comments on the GitHub PR. Could you please fix the e-mail address in the second commit?
          Hide
          krughoff Simon Krughoff added a comment -

          O.K. fixes made. Fixed email. Will merge after jenkins run.

          Show
          krughoff Simon Krughoff added a comment - O.K. fixes made. Fixed email. Will merge after jenkins run.
          Hide
          krughoff Simon Krughoff added a comment -

          Merged.

          Show
          krughoff Simon Krughoff added a comment - Merged.
          Hide
          price Paul Price added a comment -

          I forgot to add that I originally expected you would remove DatasetConfig.ref_dataset_name, but I think it's a useful thing to keep since directory names are easily changed, and so it's useful to have a name that sticks.

          Show
          price Paul Price added a comment - I forgot to add that I originally expected you would remove DatasetConfig.ref_dataset_name , but I think it's a useful thing to keep since directory names are easily changed, and so it's useful to have a name that sticks.

            People

            Assignee:
            krughoff Simon Krughoff
            Reporter:
            krughoff Simon Krughoff
            Reviewers:
            Paul Price
            Watchers:
            Colin Slater, Paul Price, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.