Fix Version/s: None
Component/s: meas_algorithms, pipe_tasks
Sprint:DRP S17-5, DRP S17-6
Team:Data Release Production
The PSF modeling tasks conveniently create and set flags indicating which sources were used to determine the PSF model. The single-frame astrometric and photometric calibration tasks should do the same, indicating at least (for each procedure):
- Which sources were selected for potential matching.
- Which sources were actually matched.
- Which sources were actually used for calibration.
As we have done in PSF modeling, it would also be good to have the ability to reserve a set of candidate sources for validation purposes.
John Parejko and/or Chris Morrison [X] may have opinions on how this interacts with the new source selection stuff they've been working on.
DM-813 PhotoCalTask doesn't return information about which stars were used in calibration
- is triggered by
RFC-330 Naming conventions for calibration sources
- relates to
DM-6655 Webpage of flags produced by various stack products
- To Do
DM-11866 Propagate astrometry and photometry visit calibration flags to coadds
DM-6887 Document the semantics of measurement algorithm flags
- Won't Fix
RFC-198 Cleanup and unify star selector call signatures
DM-7099 Improve astrometry-related flags and output
- Won't Fix
Re: running a linter, that's the easiest way to ensure your code matches our style guide. You can run it on the commandline, and there are plugins for many text editors.
Have you run a linter on these changes? There was also one more typo that I just pointed out.
Please rebase flatten before merging.
These changes to meas_astrom and pipe_tasks now moved to tickets/
DM-9050as John instructed. Second merge of this branch for meas_astrom.
I made the change in the last comment to remove doWriteOutput from photoCal.py. It seems to pass the Jenkins build. If anyone objects, please comment.