Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9050

Add flags for sources used in astrometric and photometric calibration

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Epic Link:
    • Sprint:
      DRP S17-5, DRP S17-6
    • Team:
      Data Release Production

      Description

      The PSF modeling tasks conveniently create and set flags indicating which sources were used to determine the PSF model. The single-frame astrometric and photometric calibration tasks should do the same, indicating at least (for each procedure):

      • Which sources were selected for potential matching.
      • Which sources were actually matched.
      • Which sources were actually used for calibration.

      As we have done in PSF modeling, it would also be good to have the ability to reserve a set of candidate sources for validation purposes.

      John Parejko and/or Chris Morrison [X] may have opinions on how this interacts with the new source selection stuff they've been working on.

        Attachments

          Issue Links

          duplicates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-813 PhotoCalTask doesn't return information about which stars were used in calibration

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-330 Naming conventions for calibration sources

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6655 Webpage of flags produced by various stack products

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11866 Propagate astrometry and photometry visit calibration flags to coadds

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6887 Document the semantics of measurement algorithm flags

          • Won't Fix

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-198 Cleanup and unify star selector call signatures

          • Implemented

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-7099 Improve astrometry-related flags and output

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            45 older comments
            Hide
            Permalink
            pgee Perry Gee added a comment -

            These changes to meas_astrom and pipe_tasks now moved to tickets/DM-9050 as John instructed. Second merge of this branch for meas_astrom.

            I made the change in the last comment to remove doWriteOutput from photoCal.py. It seems to pass the Jenkins build. If anyone objects, please comment.

            Show
            pgee Perry Gee added a comment - These changes to meas_astrom and pipe_tasks now moved to tickets/ DM-9050 as John instructed. Second merge of this branch for meas_astrom. I made the change in the last comment to remove doWriteOutput from photoCal.py. It seems to pass the Jenkins build. If anyone objects, please comment.
            Hide
            Permalink
            pgee Perry Gee added a comment -

            Please ignore the pull request on u/pgee/tickets/DM-9050. I'm not sure how to remove this. The pull request on tickets/DM-9050 is correct.

            The branch tickets/DM-9050 on pipe_tasks was altered. I assume that the changes will be visible on the original tickets/DM-9050 pull request?

            Show
            pgee Perry Gee added a comment - Please ignore the pull request on u/pgee/tickets/ DM-9050 . I'm not sure how to remove this. The pull request on tickets/ DM-9050 is correct. The branch tickets/ DM-9050 on pipe_tasks was altered. I assume that the changes will be visible on the original tickets/ DM-9050 pull request?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Re: running a linter, that's the easiest way to ensure your code matches our style guide. You can run it on the commandline, and there are plugins for many text editors.

            https://developer.lsst.io/coding/python_style_guide.html#code-may-be-validated-with-flake8

            Show
            Parejkoj John Parejko added a comment - Re: running a linter, that's the easiest way to ensure your code matches our style guide. You can run it on the commandline, and there are plugins for many text editors. https://developer.lsst.io/coding/python_style_guide.html#code-may-be-validated-with-flake8
            Hide
            Permalink
            pgee Perry Gee added a comment -

            Sorry, I screwed up the last commit. It's fixed now.

            Show
            pgee Perry Gee added a comment - Sorry, I screwed up the last commit. It's fixed now.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Have you run a linter on these changes? There was also one more typo that I just pointed out.

            Please rebase flatten before merging.

            Show
            Parejkoj John Parejko added a comment - Have you run a linter on these changes? There was also one more typo that I just pointed out. Please rebase flatten before merging.

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.