Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9059

Create test suite for pipe_drivers

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
      None

      Description

      pipe_drivers currently does not have a test suite (for a number of reasons), but it needs one to prevent breakage. We could take some inspiration from the tests in pipe_tasks, and put something together in pipe_drivers. An alternative approach would be to modify ci_hsc to use the pipe_drivers scripts; that might allow us to break it out the scons mold that seems to annoy some people.

        Attachments

          Issue Links

            Activity

            price Paul Price created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-7756 [ DM-7756 ]
            Hide
            yusra Yusra AlSayyad added a comment -

            We should at least make a minimal test that imports the Tasks and enable flake8 and Travis to prevent code with undefined variable names getting merged that require later fixing (e.g. DM-15534).

            airglow:pipe_drivers yusra$ flake8   --ignore=E133,E226,E228,N802,N803,N806 | grep name
            ./python/lsst/pipe/drivers/__init__.py:2:1: F403 'from .version import *' used; unable to detect undefined names
            ./python/lsst/pipe/drivers/multiBandDriver.py:419:21: F821 undefined name 'dataRef'
            ./python/lsst/pipe/drivers/multiBandDriver.py:429:36: F821 undefined name 'dataRef'
            ./python/lsst/pipe/drivers/skyCorrection.py:197:17: F821 undefined name 'maskedImage'
            

            Show
            yusra Yusra AlSayyad added a comment - We should at least make a minimal test that imports the Tasks and enable flake8 and Travis to prevent code with undefined variable names getting merged that require later fixing (e.g. DM-15534 ). airglow:pipe_drivers yusra$ flake8 --ignore=E133,E226,E228,N802,N803,N806 | grep name ./python/lsst/pipe/drivers/__init__.py:2:1: F403 'from .version import *' used; unable to detect undefined names ./python/lsst/pipe/drivers/multiBandDriver.py:419:21: F821 undefined name 'dataRef' ./python/lsst/pipe/drivers/multiBandDriver.py:429:36: F821 undefined name 'dataRef' ./python/lsst/pipe/drivers/skyCorrection.py:197:17: F821 undefined name 'maskedImage'
            yusra Yusra AlSayyad made changes -
            Risk Score 0
            yusra Yusra AlSayyad made changes -
            Epic Link DM-14405 [ 79812 ]
            Hide
            jbosch Jim Bosch added a comment -

            Yusra AlSayyad, Sophie Reed, Dan Taranu: I've created some sub-task tickets to track the work we started last Thursday.  Let's use DM-9059 as the integration branch for these, and merge that to master when all of the sub-tasks are done (except maybe DM-16263, which is pretty independent).

             

             

            Show
            jbosch Jim Bosch added a comment - Yusra AlSayyad , Sophie Reed , Dan Taranu : I've created some sub-task tickets to track the work we started last Thursday.  Let's use DM-9059 as the integration branch for these, and merge that to master when all of the sub-tasks are done (except maybe DM-16263 , which is pretty independent).    
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            jbosch Jim Bosch added a comment -

            I think I've got the first piece (base ci_hsc data package that installs) done.  Dan Taranu and Yusra AlSayyad, could you please try (on lsst-dev):

            # <load LSST environment as usual>
            export EUPS_PATH=/home/jbosch/local/20181012:$EUPS_PATH
            setup -v ci_hsc w.2018.42-3-gf5cd74e
            # <setup your derived ci_hsc_X with -k>
            # <run your derived ci_hsc_X

            That ci_hsc setup should bring in a custom version of sconsUtils as well (I needed to patch that to get installation of symlinks working properly).

            If you're especially brave, you can take a look at the last commit to ci_hsc tickets/DM-9059 to see if you can make similar changes to your SConstruct to get it to install as well.

            Show
            jbosch Jim Bosch added a comment - I think I've got the first piece (base ci_hsc data package that installs) done.  Dan Taranu and Yusra AlSayyad , could you please try (on lsst-dev): # <load LSST environment as usual> export EUPS_PATH=/home/jbosch/local/ 20181012 :$EUPS_PATH setup -v ci_hsc w. 2018.42 - 3 -gf5cd74e # <setup your derived ci_hsc_X with -k> # <run your derived ci_hsc_X That ci_hsc setup should bring in a custom version of sconsUtils as well (I needed to patch that to get installation of symlinks working properly). If you're especially brave, you can take a look at the last commit to ci_hsc tickets/ DM-9059 to see if you can make similar changes to your SConstruct to get it to install as well.
            jbosch Jim Bosch made changes -
            Link This issue is triggered by RFC-542 [ RFC-542 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-14405 [ 79812 ] DM-16678 [ 235238 ]
            frossie Frossie Economou made changes -
            Status Admin Review [ 3 ] In Progress [ 11605 ]
            frossie Frossie Economou made changes -
            Status Review [ 11605 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16678 [ 235238 ] DM-20164 [ 323028 ]
            Hide
            dtaranu Dan Taranu added a comment -

            Is it safe to mark everything here as invalid or won't fix due to DM-19817?

            Show
            dtaranu Dan Taranu added a comment - Is it safe to mark everything here as invalid or won't fix due to DM-19817 ?
            yusra Yusra AlSayyad made changes -
            Epic Link DM-20164 [ 323028 ] DM-21252 [ 414682 ]
            Hide
            dtaranu Dan Taranu added a comment -

            I believe this has been invalidated by RFC-599 and related tickets.

            Show
            dtaranu Dan Taranu added a comment - I believe this has been invalidated by RFC-599 and related tickets.
            dtaranu Dan Taranu made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Invalid [ 11005 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                price Paul Price
                Watchers:
                Dan Taranu, Jim Bosch, Paul Price, Yusra AlSayyad
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel