Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9068

Licensing in codekit no longer pushes changes.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Somewhere in the codekit refactor we lost the ability to push licensing changes.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          athornton Adam Thornton added a comment -

          Here's how to test this:

          1) create a repository with a file with an old-style license in it, or just use https://github.com/lsst-sqre/ck-tester.git
          2) create a codekit venv (Python3)
          3) Set up your token file if you need to
          4) lsst-bp -u <your-GH-id> -o lsst-sqre --repo ck-tester --branch fixit
          5) make sure that branch "fixit" of ck-tester has the changes you expect (separate LICENSE/COPYRIGHT, pointer to them in .py file)
          6) delete branch "fixit"
          7) repeat 2-6 with Python 2.

          Show
          athornton Adam Thornton added a comment - Here's how to test this: 1) create a repository with a file with an old-style license in it, or just use https://github.com/lsst-sqre/ck-tester.git 2) create a codekit venv (Python3) 3) Set up your token file if you need to 4) lsst-bp -u <your-GH-id> -o lsst-sqre --repo ck-tester --branch fixit 5) make sure that branch "fixit" of ck-tester has the changes you expect (separate LICENSE/COPYRIGHT, pointer to them in .py file) 6) delete branch "fixit" 7) repeat 2-6 with Python 2.
          Hide
          Permalink
          athornton Adam Thornton added a comment -

          PR is at: https://github.com/lsst-sqre/sqre-codekit/pull/18

          Show
          athornton Adam Thornton added a comment - PR is at: https://github.com/lsst-sqre/sqre-codekit/pull/18
          Hide
          Permalink
          athornton Adam Thornton added a comment -

          PR reviewed and merged.

          Show
          athornton Adam Thornton added a comment - PR reviewed and merged.

            People

            Assignee:
            athornton Adam Thornton
            Reporter:
            athornton Adam Thornton
            Reviewers:
            Angelo Fausti, Frossie Economou, J Matt Peterson [X] (Inactive), Jonathan Sick, Joshua Hoblitt
            Watchers:
            Adam Thornton, Angelo Fausti, Frossie Economou, J Matt Peterson [X] (Inactive), Jonathan Sick, Joshua Hoblitt
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: