Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9075

Make standard measurement algorithms less chatty

    XMLWordPrintable

Details

    • Story
    • Status: Won't Fix
    • Resolution: Done
    • None
    • meas_base
    • None
    • 2
    • Data Release Production

    Description

      On a ci_hsc run, I noticed the following errors being repeated multiple times:

      forcedPhotCcd.measurement WARN: Error in base_GaussianFlux.measure on record 775958096257221935: 
        File "src/SdssShape.cc", line 905, in static lsst::meas::base::FluxResult lsst::meas::base::SdssShapeAlgorithm::computeFixedMomentsFlux(const ImageT&, const lsst::afw::geom::ellipses::Quadrupole&, const Point2D&) [with ImageT = lsst::afw::image::MaskedImage<float, short unsigned int, float>; lsst::afw::geom::Point2D = lsst::afw::geom::Point<double, 2>]
          Center (1372,-1) not in image (2048x4176) {0}
      lsst::pex::exceptions::RuntimeError: 'Center (1372,-1) not in image (2048x4176)'
       
      forcedPhotCcd.measurement WARN: Error in base_CircularApertureFlux.measure on record 775958096257222342: 
        File "src/image/Image.cc", line 91, in static lsst::afw::image::ImageBase<PixelT>::_view_t lsst::afw::image::ImageBase<PixelT>::_makeSubView(const Extent2I&, const Extent2I&, const _view_t&) [with PixelT = float; lsst::afw::image::ImageBase<PixelT>::_view_t = boost::gil::image_view<boost::gil::memory_based_2d_locator<boost::gil::memory_based_step_iterator<boost::gil::pixel<float, boost::gil::layout<boost::mpl::vector1<boost::gil::gray_color_t> > >*> > >; lsst::afw::geom::Extent2I = lsst::afw::geom::Extent<int, 2>]
          Box2I(Point2I(-336,36),Extent2I(0,0)) doesn't fit in image 15x15 {0}
      lsst::pex::exceptions::LengthError: 'Box2I(Point2I(-336,36),Extent2I(0,0)) doesn't fit in image 15x15'
      

      Scanning the code, I think there are several instances of regular exceptions (i.e., not MeasurementError) being thrown, which produce the chat. Errors that are expected for common situations (e.g., centroid off image, bounding box off image, singular matrix) should be converted to throw MeasurementError to silence them.

      Attachments

        Issue Links

          Activity

            I don't think we'll ever address this ticket as written: it's too open ended and ill defined to be “less chatty”.

            I'm closing it down, but invite folks to file further tickets for specific changes which need to be made.

            swinbank John Swinbank added a comment - I don't think we'll ever address this ticket as written: it's too open ended and ill defined to be “less chatty”. I'm closing it down, but invite folks to file further tickets for specific changes which need to be made.

            People

              Unassigned Unassigned
              price Paul Price
              John Swinbank, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.