Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9093

Fix "default" refcat filter in jointcal.run()

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None

      Description

      jointcal.py originally had this line:

              # Determine default filter associated to the catalog
              filt, mfilt = list(andConfig.magColumnMap.items())[0]
      

      The preceding comment is incorrect, and jointcal should be able to deal with different filters in the refcat.

      I've changed it to use the most common filter from the input catalog (as parsed by loadSkyCircle), which is slightly less bad, but we need to figure out what to do when someone passes dataRefs with multiple filters to jointcal. Jointcal should be refactored to use the filters of the exposure being fit when accessing the reference catalog (i.e., to bundle the exposures and refcats appropriately by filter).

      I've added a note referencing this ticket to the relevant part of jointcal.py

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Reviewed for DM-CCB, 2020-08-25. This remains an open issue.

            Show
            swinbank John Swinbank added a comment - Reviewed for DM-CCB, 2020-08-25. This remains an open issue.
            Hide
            Parejkoj John Parejko added a comment -

            I'm not closing this yet, but jointcal's use for photometry is fading out (it's disabled in HSC gen3 now). This may still be relevant for astrometry, if we want to do cross-filter astrometric fitting.

            Show
            Parejkoj John Parejko added a comment - I'm not closing this yet, but jointcal's use for photometry is fading out (it's disabled in HSC gen3 now). This may still be relevant for astrometry, if we want to do cross-filter astrometric fitting.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Dominique Boutigny, John Parejko, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.