Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9120

matcherSourceSelector incorrectly uses nChild and footprints in isMultiple test.

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production S17 - 1, Alert Production S17 - 2
    • Team:
      Alert Production

      Description

      This bug was found by dm-square as a drop in match rms quality. The replacement for the SourceInfo class in matchOptimisticB.py has a test for isMultiple but this test was not used in the subsequent isGood or isUsable tests. The current implementation of the new matcherSourceSelector incorrectly uses this test and to parrot the performance of SourceInfo (which was the goal of DM-6824) this test should be removed.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6824 Use meas.algorithms.astrometrySourceSelector in measOptimisticB

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8645 Implement new matcherSourceSelector object for use in matchOptimisticB code. This links to DM-6824.

          • Done

            Activity

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Reviewers:
              Simon Krughoff
              Watchers:
              Chris Morrison [X] (Inactive), Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.