Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9125

Make SGS: plotsScript.py: makeRachelPlots work!

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 4
    • DRP S17-3
    • Data Release Production

    Description

      In order to test the makeRachelPlots function, a new HSC database dump is required.

      Attachments

        Issue Links

          Activity

            Result of running the function makeRachelPlots

            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Result of running the function makeRachelPlots

            With an updated HSC catalog, we are now able to generate plots such as

            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - With an updated HSC catalog, we are now able to generate plots such as

            Hi John,
            I can run all the way through the SGS workflow now and succesfully run the makeRachelPlots function in plotsScript.py (output attached). Can you please review the work done on this ticket?

            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Hi John, I can run all the way through the SGS workflow now and succesfully run the makeRachelPlots function in plotsScript.py (output attached). Can you please review the work done on this ticket?

            I think the ticket branches need rebasing onto the current state of DM-9002. I'll do that as part of my review (unless vpk24 objects before I get around to it!).

            swinbank John Swinbank added a comment - I think the ticket branches need rebasing onto the current state of DM-9002 . I'll do that as part of my review (unless vpk24 objects before I get around to it!).

            I have created the branch tickets/DM-9125b in sgs which I believe is correctly rebased on top of tickets/DM-9002, and it's that which I intend to review.

            vpk24, please ensure that you agree with me, and having done so, that you delete the existing tickets/DM-9125 and replace it with the properly rebased code before you merge.

            swinbank John Swinbank added a comment - I have created the branch tickets/DM-9125b in sgs which I believe is correctly rebased on top of tickets/ DM-9002 , and it's that which I intend to review. vpk24 , please ensure that you agree with me, and having done so, that you delete the existing tickets/ DM-9125 and replace it with the properly rebased code before you merge.

            Comments on PRs in:

            No serious issues, but I am a bit worried about the profusion of strings like udeepwide appearing all over the place. They don't seem to be properly described (or, indeed, mentioned at all) in the README, and it's going to make it very hard for new users to understand which bits of code they're supposed to edit when processing a new dataset.

            Also, please add a description of what makeRachelPlots actually does. Even better if you rename it to something descriptive.

            swinbank John Swinbank added a comment - Comments on PRs in: sgsupervised sgs No serious issues, but I am a bit worried about the profusion of strings like udeepwide appearing all over the place. They don't seem to be properly described (or, indeed, mentioned at all) in the README, and it's going to make it very hard for new users to understand which bits of code they're supposed to edit when processing a new dataset. Also, please add a description of what makeRachelPlots actually does. Even better if you rename it to something descriptive.

            Hi John,
            Can you take one more look at DM-9125?

            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Hi John, Can you take one more look at DM-9125 ?

            Rebased and merged.

            swinbank John Swinbank added a comment - Rebased and merged.

            People

              vpk24 Vishal Kasliwal [X] (Inactive)
              vpk24 Vishal Kasliwal [X] (Inactive)
              John Swinbank
              John Swinbank, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.