Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9125

Make SGS: plotsScript.py: makeRachelPlots work!

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In order to test the makeRachelPlots function, a new HSC database dump is required.

        Attachments

          Issue Links

            Activity

            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Result of running the function makeRachelPlots

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Result of running the function makeRachelPlots
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            With an updated HSC catalog, we are now able to generate plots such as

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - With an updated HSC catalog, we are now able to generate plots such as
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Hi John,
            I can run all the way through the SGS workflow now and succesfully run the makeRachelPlots function in plotsScript.py (output attached). Can you please review the work done on this ticket?

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Hi John, I can run all the way through the SGS workflow now and succesfully run the makeRachelPlots function in plotsScript.py (output attached). Can you please review the work done on this ticket?
            Hide
            swinbank John Swinbank added a comment -

            I think the ticket branches need rebasing onto the current state of DM-9002. I'll do that as part of my review (unless Vishal Kasliwal [X] objects before I get around to it!).

            Show
            swinbank John Swinbank added a comment - I think the ticket branches need rebasing onto the current state of DM-9002 . I'll do that as part of my review (unless Vishal Kasliwal [X] objects before I get around to it!).
            Hide
            swinbank John Swinbank added a comment -

            I have created the branch tickets/DM-9125b in sgs which I believe is correctly rebased on top of tickets/DM-9002, and it's that which I intend to review.

            Vishal Kasliwal [X], please ensure that you agree with me, and having done so, that you delete the existing tickets/DM-9125 and replace it with the properly rebased code before you merge.

            Show
            swinbank John Swinbank added a comment - I have created the branch tickets/DM-9125b in sgs which I believe is correctly rebased on top of tickets/ DM-9002 , and it's that which I intend to review. Vishal Kasliwal [X] , please ensure that you agree with me, and having done so, that you delete the existing tickets/ DM-9125 and replace it with the properly rebased code before you merge.
            Hide
            swinbank John Swinbank added a comment -

            Comments on PRs in:

            No serious issues, but I am a bit worried about the profusion of strings like udeepwide appearing all over the place. They don't seem to be properly described (or, indeed, mentioned at all) in the README, and it's going to make it very hard for new users to understand which bits of code they're supposed to edit when processing a new dataset.

            Also, please add a description of what makeRachelPlots actually does. Even better if you rename it to something descriptive.

            Show
            swinbank John Swinbank added a comment - Comments on PRs in: sgsupervised sgs No serious issues, but I am a bit worried about the profusion of strings like udeepwide appearing all over the place. They don't seem to be properly described (or, indeed, mentioned at all) in the README, and it's going to make it very hard for new users to understand which bits of code they're supposed to edit when processing a new dataset. Also, please add a description of what makeRachelPlots actually does. Even better if you rename it to something descriptive.
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Hi John,
            Can you take one more look at DM-9125?

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Hi John, Can you take one more look at DM-9125 ?
            Hide
            swinbank John Swinbank added a comment -

            Rebased and merged.

            Show
            swinbank John Swinbank added a comment - Rebased and merged.

              People

              • Assignee:
                vpk24 Vishal Kasliwal [X] (Inactive)
                Reporter:
                vpk24 Vishal Kasliwal [X] (Inactive)
                Reviewers:
                John Swinbank
                Watchers:
                John Swinbank, Vishal Kasliwal [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel