Fix Version/s: None
In order to test the makeRachelPlots function, a new HSC database dump is required.
- is blocked by
DM-9002 Fix & document S/G code
I can run all the way through the SGS workflow now and succesfully run the makeRachelPlots function in plotsScript.py (output attached). Can you please review the work done on this ticket?
I think the ticket branches need rebasing onto the current state of
DM-9002. I'll do that as part of my review (unless Vishal Kasliwal [X] objects before I get around to it!).
I have created the branch tickets/DM-9125b in sgs which I believe is correctly rebased on top of tickets/
DM-9002, and it's that which I intend to review.
Vishal Kasliwal [X], please ensure that you agree with me, and having done so, that you delete the existing tickets/
DM-9125 and replace it with the properly rebased code before you merge.
Comments on PRs in:
No serious issues, but I am a bit worried about the profusion of strings like udeepwide appearing all over the place. They don't seem to be properly described (or, indeed, mentioned at all) in the README, and it's going to make it very hard for new users to understand which bits of code they're supposed to edit when processing a new dataset.
Also, please add a description of what makeRachelPlots actually does. Even better if you rename it to something descriptive.
Can you take one more look at
Result of running the function makeRachelPlots