Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9131

Apply second round of Robert's LDM-151 comments

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      DRP S17-3, DRP S17-4
    • Team:
      Data Release Production

      Description

      Having applied Robert's first round of corrections, a second marked-up pdf with many few comments exists which should be applied during this iteration on LDM-151.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8066 Edit CPP section of LDM-151

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9132 Act on Robert and Zeljko's requests for tweaks LDM-151 from yesterday's chat

          • Done

            Activity

            Ascending order - Click to sort in descending order
            9 older comments
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment - - edited

            Tried and failed, looks like I don't have push access to the draft branch, it's complaining that 

            Counting objects: 11, done.
            		 
            Delta compression using up to 8 threads.
            		 
            Compressing objects: 100% (11/11), done.
            		 
            Writing objects: 100% (11/11), 9.63 KiB | 0 bytes/s, done.
            		 
            Total 11 (delta 8), reused 0 (delta 0)
            		 
            remote: Resolving deltas: 100% (8/8), completed with 5 local objects.
            		 
            remote: error: GH006: Protected branch update failed for refs/heads/draft.
            		 
            remote: error: Required status check "continuous-integration/travis-ci" is expected.
            		 
            To http://github.com/lsst/ldm-151
            		 
             ! [remote rejected] draft -> draft (protected branch hook declined)
            		 
            error: failed to push some refs to 'http://github.com/lsst/ldm-151'

            Any idea what I do to fix that?

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - - edited Tried and failed, looks like I don't have push access to the draft branch, it's complaining that Counting objects: 11, done. Delta compression using up to 8 threads. Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 9.63 KiB | 0 bytes/s, done. Total 11 (delta 8), reused 0 (delta 0) remote: Resolving deltas: 100% (8/8), completed with 5 local objects. remote: error: GH006: Protected branch update failed for refs/heads/draft. remote: error: Required status check "continuous-integration/travis-ci" is expected. To http://github.com/lsst/ldm-151 ! [remote rejected] draft -> draft (protected branch hook declined) error: failed to push some refs to 'http://github.com/lsst/ldm-151' Any idea what I do to fix that?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            You make a pull request. The pull request passes. Travis checks work. You hit the Merge button on Github. You should be able to push to a ticket branch.

            Note: read the error message and it says exactly this.

            Show
            tjenness Tim Jenness added a comment - You make a pull request. The pull request passes. Travis checks work. You hit the Merge button on Github. You should be able to push to a ticket branch. Note: read the error message and it says exactly this.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks Tim. Merlin, you are a bad person (as am I, for not checking that it was merged). Reopening this until the work is done properly.

            Show
            swinbank John Swinbank added a comment - Thanks Tim. Merlin, you are a bad person (as am I, for not checking that it was merged). Reopening this until the work is done properly.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            I am indeed a terrible person. However, I believe this is now done, so I am marking this as "In Review". Please either berate me for my incompetence and tell me how to fix it, or switch it over to "Done".

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I am indeed a terrible person. However, I believe this is now done, so I am marking this as "In Review". Please either berate me for my incompetence and tell me how to fix it, or switch it over to "Done".
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            PS All the work done here was merged on ticket branch DM-8066

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - PS All the work done here was merged on ticket branch DM-8066

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Merlin Fisher-Levine, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.