Details
-
Type:
Story
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:4
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
While wrapping pipe_tasks for pybind11, I found a cosmetic bug in which a method's docstring reported some parameter types in C++ style and others in python style:
1. (self: lsst.meas.base._sdssCentroid.SdssCentroidTransform, inputCatalog: lsst.afw.table._source.SourceCatalog, outputCatalog: lsst.afw.table._base.BaseCatalog, wcs: lsst::afw::image::Wcs, calib: lsst::afw::image::Calib) -> None
The problem was fixed by importing Wcs and Calib before importing the pybind11 wrapper, but I've since seen the same problem in other methods. We should audit the pybind11 wrappers to ensure that their types are always reported in python terms.
Attachments
Activity
Krzysztof Findeisen
created issue -
Krzysztof Findeisen
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
Krzysztof Findeisen
made changes -
| Labels | pybind11 | SciencePipelines pybind11 |
Krzysztof Findeisen
made changes -
| Remote Link | This issue links to "Page (Confluence)" [ 25899 ] |
| Team | Data Release Production [ 10301 ] | |
| Urgent? | off | |
| Labels | SciencePipelines pybind11 | pybind11 |
| Resolution | Done [ 10000 ] | |
| Status | To Do [ 10001 ] | Won't Fix [ 10405 ] |
It seems unlikely that we'll ever find effort to go through and audit all of the wrappers for this, much as I'd like to. I suggest closing this ticket as “Won't Fix”, and addressing individual problems as we come across them.