Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9156

Wrap ci_hsc with pybind11

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      DRP S17-3
    • Team:
      Data Release Production

      Attachments

        Issue Links

          Activity

          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          CI still running. But passed on MacOS with Python 2.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - CI still running. But passed on MacOS with Python 2.
          Hide
          rowen Russell Owen added a comment -

          Looks great. I had a few comments on github.

          Show
          rowen Russell Owen added a comment - Looks great. I had a few comments on github.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Ok, with fix to sconsUtils and obs_subaru now passes Jenkins. Ready to merge. @rowen, do you want to have a look at those changes first?

          I also implemented your requested changes of course...

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Ok, with fix to sconsUtils and obs_subaru now passes Jenkins. Ready to merge. @rowen, do you want to have a look at those changes first? I also implemented your requested changes of course...
          Hide
          rowen Russell Owen added a comment -

          I'm glad you were able to get obs_subaru building reliably. That looks like a lot of work.

          I found a few things that need updating in obs_subaru.

          I didn't see any changes in afw on github, though I was expecting some (e.g. modernization of one wrapper as per my own changes to it and wrapping the remaining methods of another object).

          Show
          rowen Russell Owen added a comment - I'm glad you were able to get obs_subaru building reliably. That looks like a lot of work. I found a few things that need updating in obs_subaru. I didn't see any changes in afw on github, though I was expecting some (e.g. modernization of one wrapper as per my own changes to it and wrapping the remaining methods of another object).

            People

            • Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel