Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9170

Implement PSF convolution operator in 2D

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Peter Melchior will supply the 1D version of this.

      Work should be done based on a PSF image supplied by the stack.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            The commit history is a bit convoluted since it is based off of DM-9171, which is still in review. Just see the commit Create PSF Convolution Operator for the PSF operator, and examples/testPSF.ipynb to visualize the operator and it's application to an array with a single pixel turned on.

            Show
            fred3m Fred Moolekamp added a comment - The commit history is a bit convoluted since it is based off of DM-9171 , which is still in review. Just see the commit Create PSF Convolution Operator for the PSF operator, and examples/testPSF.ipynb to visualize the operator and it's application to an array with a single pixel turned on.
            Hide
            pmelchior Peter Melchior added a comment -

            The test looks good, but it won't show if the operator flips the PSF image. Please perform this test with a PSF that is not symmetric, e.g. by adding a bright pixel at some location that isn't along the coordinate axes or the diagonal (e.g. (-1,2) if the center is (0,0)).

            Also, can you measure the second moments of the PSF and the convolved image. The trace width sqrt(Q_xx + Q_yy) should differ by 1/12 of a pixel.

            Show
            pmelchior Peter Melchior added a comment - The test looks good, but it won't show if the operator flips the PSF image. Please perform this test with a PSF that is not symmetric, e.g. by adding a bright pixel at some location that isn't along the coordinate axes or the diagonal (e.g. (-1,2) if the center is (0,0)). Also, can you measure the second moments of the PSF and the convolved image. The trace width sqrt(Q_xx + Q_yy) should differ by 1/12 of a pixel.
            Hide
            fred3m Fred Moolekamp added a comment -

            Good point, it turns out that I did flip both the horizontal and vertical axes.

            Show
            fred3m Fred Moolekamp added a comment - Good point, it turns out that I did flip both the horizontal and vertical axes.
            Hide
            fred3m Fred Moolekamp added a comment -

            I fixed the bug in the PSF operator and updated the ipython notebook.

            Show
            fred3m Fred Moolekamp added a comment - I fixed the bug in the PSF operator and updated the ipython notebook .
            Hide
            pmelchior Peter Melchior added a comment - - edited

            Yes, the notebook examples look exactly as they should.

            Show
            pmelchior Peter Melchior added a comment - - edited Yes, the notebook examples look exactly as they should.

              People

              • Assignee:
                fred3m Fred Moolekamp
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Peter Melchior
                Watchers:
                Fred Moolekamp, John Swinbank, Peter Melchior
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel