Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9187

port jointcal to pybind11

    Details

      Description

      Jointcal's python interface is currently SWIG-based. Now that most (all?) of the dependencies are converted, it's time to convert jointcal to pybind11.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Doing this now, so we can add jointcal to lsst_distrib

            Show
            Parejkoj John Parejko added a comment - Doing this now, so we can add jointcal to lsst_distrib
            Hide
            Parejkoj John Parejko added a comment -

            Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.

            Show
            Parejkoj John Parejko added a comment - Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for offering to review, Pim!

            In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _str_, but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043).

            Show
            Parejkoj John Parejko added a comment - Thanks for offering to review, Pim! In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _ str _ , but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043 ).
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Looks good. Except for the question about STL containers instead of exposing a list like thing.
            I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Looks good. Except for the question about STL containers instead of exposing a list like thing. I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks to Pim Schellart [X] for the review. Merged and done!

            Show
            Parejkoj John Parejko added a comment - Thanks to Pim Schellart [X] for the review. Merged and done!

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Pim Schellart [X] (Inactive)
                Watchers:
                John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel