Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9187

port jointcal to pybind11

    XMLWordPrintable

    Details

      Description

      Jointcal's python interface is currently SWIG-based. Now that most (all?) of the dependencies are converted, it's time to convert jointcal to pybind11.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9752 Add jointcal to lsst_distrib

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-300 Add jointcal to lsst_distrib

          • Implemented
          is blocked by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6168 Wrap afw using pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6302 Wrap pex_exceptions with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8421 Wrap pipe_base with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8453 Wrap meas_algorithms with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8458 Wrap meas_astrom with pybind11

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Doing this now, so we can add jointcal to lsst_distrib

            Show
            Parejkoj John Parejko added a comment - Doing this now, so we can add jointcal to lsst_distrib
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.

            Show
            Parejkoj John Parejko added a comment - Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for offering to review, Pim!

            In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _str_, but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043).

            Show
            Parejkoj John Parejko added a comment - Thanks for offering to review, Pim! In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _ str _ , but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043 ).
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Looks good. Except for the question about STL containers instead of exposing a list like thing.
            I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Looks good. Except for the question about STL containers instead of exposing a list like thing. I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks to Pim Schellart [X] for the review. Merged and done!

            Show
            Parejkoj John Parejko added a comment - Thanks to Pim Schellart [X] for the review. Merged and done!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.