Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9187

port jointcal to pybind11

    XMLWordPrintable

    Details

      Description

      Jointcal's python interface is currently SWIG-based. Now that most (all?) of the dependencies are converted, it's time to convert jointcal to pybind11.

        Attachments

          Issue Links

            Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue is blocked by DM-6168 [ DM-6168 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-6302 [ DM-6302 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-8421 [ DM-8421 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-8453 [ DM-8453 ]
            Parejkoj John Parejko made changes -
            Link This issue is blocked by DM-8458 [ DM-8458 ]
            krughoff Simon Krughoff made changes -
            Epic Link DM-8472 [ 28104 ]
            krughoff Simon Krughoff made changes -
            Sprint Alert Production S17 - 2 [ 361 ]
            krughoff Simon Krughoff made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Rank Ranked lower
            Parejkoj John Parejko made changes -
            Rank Ranked higher
            Parejkoj John Parejko made changes -
            Sprint Alert Production S17 - 3 [ 605 ]
            krughoff Simon Krughoff made changes -
            Epic Link DM-8472 [ 28104 ] DM-9680 [ 30785 ]
            Parejkoj John Parejko made changes -
            Link This issue blocks RFC-300 [ RFC-300 ]
            Parejkoj John Parejko made changes -
            Link This issue blocks DM-9752 [ DM-9752 ]
            Hide
            Parejkoj John Parejko added a comment -

            Doing this now, so we can add jointcal to lsst_distrib

            Show
            Parejkoj John Parejko added a comment - Doing this now, so we can add jointcal to lsst_distrib
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Parejkoj John Parejko added a comment -

            Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.

            Show
            Parejkoj John Parejko added a comment - Good news! With the latest commit, jointcal runs with pybind11 now. Now to decide how much extra syntactic sugar to add.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for offering to review, Pim!

            In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _str_, but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043).

            Show
            Parejkoj John Parejko added a comment - Thanks for offering to review, Pim! In addition to the pybind11, I cleaned up some of the interface and renamed things. The only pybind11 wrappers I did above and beyond "just get it working" was making sure all the *Star classes had _ str _ , but that's still not wildly helpful, because the *StarLists are still opaque (see notes on DM-4043 ).
            Parejkoj John Parejko made changes -
            Reviewers Pim Schellart [ pschella ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Looks good. Except for the question about STL containers instead of exposing a list like thing.
            I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Looks good. Except for the question about STL containers instead of exposing a list like thing. I made some minor comments on the C++ (couldn't resist) but in general I have tried to focus only on the wrapping.
            pschella Pim Schellart [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Parejkoj John Parejko added a comment -

            Thanks to Pim Schellart [X] for the review. Merged and done!

            Show
            Parejkoj John Parejko added a comment - Thanks to Pim Schellart [X] for the review. Merged and done!
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.