Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9188

Cleanup pybind11 code in core meas and ip packages

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP S17-3, DRP S17-4
    • Team:
      Data Release Production

      Description

      Use the checklist from DM-9182 to clean up code in the packages listed in the components field.

      Unlike DM-9182, I have not reviewed these packages for specific issues in advance; now that the common problems have been identified it'll be easier to review and fix at the same time.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9100 Merge pybind11 branches to master

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9099 Begin cleanup of pybind11 branch

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9063 Audit pybind11 port for outstanding technical debt

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9528 Cleanup pybind11 code in meas_deblender

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            ip_isr done

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - ip_isr done
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            meas_algorithms done

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - meas_algorithms done
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            meas_astrom done

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - meas_astrom done
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            meas_base done, pending changes in DM-8888 (shared_ptr holder type)

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - meas_base done, pending changes in DM-8888 ( shared_ptr holder type)
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Could you rebase these on the latest tickets/DM-8467 to clean up the diffs?

            Show
            jbosch Jim Bosch added a comment - Could you rebase these on the latest tickets/ DM-8467 to clean up the diffs?
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Rebase done.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Rebase done.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Review complete. Lots of repeats of mostly the same minor comments:

            • Putting pybind11 include first.
            • Importing symbols directly from . rather than the relevant subpackage/module. I could be convinced this is okay if you feel strongly about it; I think it's a tradeoff between robustness and encapsulation.
            • Moving __all__ above most imports.
            Show
            jbosch Jim Bosch added a comment - Review complete. Lots of repeats of mostly the same minor comments: Putting pybind11 include first. Importing symbols directly from . rather than the relevant subpackage/module. I could be convinced this is okay if you feel strongly about it; I think it's a tradeoff between robustness and encapsulation. Moving __all__ above most imports.
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Fred Moolekamp, Jim Bosch, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.