Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9188

Cleanup pybind11 code in core meas and ip packages

    XMLWordPrintable

Details

    • 4
    • DRP S17-3, DRP S17-4
    • Data Release Production

    Description

      Use the checklist from DM-9182 to clean up code in the packages listed in the components field.

      Unlike DM-9182, I have not reviewed these packages for specific issues in advance; now that the common problems have been identified it'll be easier to review and fix at the same time.

      Attachments

        Issue Links

          Activity

            ip_isr done

            pschella Pim Schellart [X] (Inactive) added a comment - ip_isr done

            meas_algorithms done

            pschella Pim Schellart [X] (Inactive) added a comment - meas_algorithms done

            meas_astrom done

            pschella Pim Schellart [X] (Inactive) added a comment - meas_astrom done

            meas_base done, pending changes in DM-8888 (shared_ptr holder type)

            pschella Pim Schellart [X] (Inactive) added a comment - meas_base done, pending changes in DM-8888 ( shared_ptr holder type)
            jbosch Jim Bosch added a comment -

            Could you rebase these on the latest tickets/DM-8467 to clean up the diffs?

            jbosch Jim Bosch added a comment - Could you rebase these on the latest tickets/ DM-8467 to clean up the diffs?

            Rebase done.

            pschella Pim Schellart [X] (Inactive) added a comment - Rebase done.
            jbosch Jim Bosch added a comment -

            Review complete. Lots of repeats of mostly the same minor comments:

            • Putting pybind11 include first.
            • Importing symbols directly from . rather than the relevant subpackage/module. I could be convinced this is okay if you feel strongly about it; I think it's a tradeoff between robustness and encapsulation.
            • Moving __all__ above most imports.
            jbosch Jim Bosch added a comment - Review complete. Lots of repeats of mostly the same minor comments: Putting pybind11 include first. Importing symbols directly from . rather than the relevant subpackage/module. I could be convinced this is okay if you feel strongly about it; I think it's a tradeoff between robustness and encapsulation. Moving __all__ above most imports.

            People

              pschella Pim Schellart [X] (Inactive)
              jbosch Jim Bosch
              Jim Bosch
              Fred Moolekamp, Jim Bosch, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.