Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9192

Implement new spatially-variable PhotoCalib model

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      16
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2, Alert Production S17 - 3, Alert Production S17 - 4
    • Team:
      Alert Production

      Description

      This ticket is for the implementation of the BoundedField-based Calib redesign that will be proposed in an upcoming RFC. The details of the design will be given below once they are settled.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9193 design new Calib object and interface

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9882 Add integrate interface to BoundedField/ChebyshevBoundedField

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-289 New spatially-variant PhotoCalib object

          • Implemented
          is triggering

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-10153 Replace Calib with finished PhotoCalib

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9195 Implement improved jointcal photometric fit

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-10395 alist[:] segfaults on centos 7 Jenkins

          • Won't Fix

          Improvement - An improvement or enhancement to an existing feature or task. DM-10260 Add "value+error" object to somewhere

          • Won't Fix

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-322 Rename "*_flux" fields to "*_instFlux" in SourceCatalogs

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            9 older comments
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks John Parejko!

            I have quickly glanced at your changes in meas_algorithms, and didn't see anything that looked immediately wrong except for this commented throw. I'm not really familiar with the code though, and it's late and my brain is fried. If Jim has chance to look at it that's great, otherwise I'll go over it more carefully tomorrow.

            Other than that, the only thing I wonder about is persistence. Did you have any further changes you wanted to make there? If not, I'll eyeball it again and then I think you're good to go.

            Show
            swinbank John Swinbank added a comment - Thanks John Parejko ! I have quickly glanced at your changes in meas_algorithms, and didn't see anything that looked immediately wrong except for this commented throw . I'm not really familiar with the code though, and it's late and my brain is fried. If Jim has chance to look at it that's great, otherwise I'll go over it more carefully tomorrow. Other than that, the only thing I wonder about is persistence. Did you have any further changes you wanted to make there? If not, I'll eyeball it again and then I think you're good to go.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Whoops on that commented throw! Thanks for catching that. Fixed.

            I believe I already incorporated your persistence suggestions (and the remaining comments from the review). I've already rebase-flattened things, but feel free to take a look.

            Show
            Parejkoj John Parejko added a comment - Whoops on that commented throw! Thanks for catching that. Fixed. I believe I already incorporated your persistence suggestions (and the remaining comments from the review). I've already rebase-flattened things, but feel free to take a look.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            One comment on the meas_algorithms PR. Otherwise looks good to me.

            Show
            jbosch Jim Bosch added a comment - One comment on the meas_algorithms PR. Otherwise looks good to me.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Looks great. Nice job, John Parejko!

            Show
            swinbank John Swinbank added a comment - Looks great. Nice job, John Parejko !
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for all the help on the review. Jenkins passed (except OSX which is running forever):

            https://ci.lsst.codes/job/stack-os-matrix/23422/

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for all the help on the review. Jenkins passed (except OSX which is running forever): https://ci.lsst.codes/job/stack-os-matrix/23422/ Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              John Swinbank
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.