Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9195

Implement improved jointcal photometric fit

    XMLWordPrintable

Details

    • 10
    • Alert Production S17 - 4, Alert Production S17 - 5, Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8, Alert Production F17 - 9, Alert Production F17 - 10
    • Alert Production

    Description

      With a new Calib object to contain the fit results and a better understanding of the meas_mosaic model, implement a better photometric model in jointcal. This should not be a "final" model (e.g. full focal plane/multi-component), but rather a "better enough" model (e.g 2d 3rd-order chebyshev per ccd). The model should be good enough to replace meas_mosaic's fit.

      Attachments

        Issue Links

          Activity

            Since I don't have a full understanding of meas_mosaic I can't comment on: "The model should be good enough to replace meas_mosaic's fit." Perhaps someone more familiar with that part (e.g. lauren or jbosch) can quickly comment on it. For other comments please see PR.

            pschella Pim Schellart [X] (Inactive) added a comment - Since I don't have a full understanding of meas_mosaic I can't comment on: "The model should be good enough to replace meas_mosaic's fit." Perhaps someone more familiar with that part (e.g. lauren or jbosch ) can quickly comment on it. For other comments please see PR.
            jbosch Jim Bosch added a comment -

            There's already a hefty ticket in the works to verify that assertion, so we don't need to do that here.

            jbosch Jim Bosch added a comment - There's already a hefty ticket in the works to verify that assertion, so we don't need to do that here.
            Parejkoj John Parejko added a comment -

            Thanks for the review, pschella: I've responded to almost all your points, but there were a few that I'd like clarification on, if you could look at the PR again, please?

            Parejkoj John Parejko added a comment - Thanks for the review, pschella : I've responded to almost all your points, but there were a few that I'd like clarification on, if you could look at the PR again, please?
            Parejkoj John Parejko added a comment -

            Jenkins run passed after a bit more cleanup! Will merge DM-11905 and then this shortly.

            https://ci.lsst.codes/job/stack-os-matrix/26883/

            Parejkoj John Parejko added a comment - Jenkins run passed after a bit more cleanup! Will merge DM-11905 and then this shortly. https://ci.lsst.codes/job/stack-os-matrix/26883/
            Parejkoj John Parejko added a comment -

            Thanks again for the review, pschella. I merged DM-11905 first, and now this. Hopefully it was fast enough to not catch any Jenkins jobs in the middle.

            Merged and done!

            Parejkoj John Parejko added a comment - Thanks again for the review, pschella . I merged DM-11905 first, and now this. Hopefully it was fast enough to not catch any Jenkins jobs in the middle. Merged and done!

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Fred Moolekamp, Pim Schellart [X] (Inactive)
              Dominique Boutigny, Fred Moolekamp, Jim Bosch, John Parejko, Lauren MacArthur, Pim Schellart [X] (Inactive), Russell Owen, Simon Krughoff (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.