Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9215

afw::math::Function should be pure-virtual

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      2
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      afw::math::Function is conceptually pure virtual but has no pure-virtual methods, making it possible to instantiate with possibly confusing results.

      My recommended fix is to move the clone() method defined in its immediate subclasses down to it. This would require switching to a nonvirtual public + protected virtual pattern to maintain covariant return types, which would require a bit more work but have other benefits.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Reviewed for DM-CCB 2020-06-24. Still valid.

            Show
            swinbank John Swinbank added a comment - Reviewed for DM-CCB 2020-06-24. Still valid.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.