Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9251

Rebase pybind11 branch onto latest master

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      DRP S17-3
    • Team:
      Data Release Production

      Attachments

        Activity

        Hide
        pschella Pim Schellart [X] (Inactive) added a comment -

        Please confirm tickets/DM-8467 builds for you.

        Show
        pschella Pim Schellart [X] (Inactive) added a comment - Please confirm tickets/ DM-8467 builds for you.
        Hide
        rowen Russell Owen added a comment -

        Yes it builds through pipe_tasks. Would you like me to build it any further?

        Also, does this update include a newer pybind11? When I build afw I'm seeing a warning I don't recall seeing before:

        python/lsst/afw/math/random.cc:96:16: warning: 'object' is deprecated: Use reinterpret_borrow<object>() or reinterpret_steal<object>() [-Wdeprecated-declarations]
                return py::object{PyBytes_FromStringAndSize(state.data(), state.size()), false};
                       ^
        /Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pybind11/tickets.DM-8467-g939e5e0649/include/pybind11/pytypes.h:106:5: note: 'object' has been explicitly marked deprecated here
            object(handle h, bool is_borrowed) : handle(h) { if (is_borrowed) inc_ref(); }
            ^
        

        (Note that I'm modifying afw/display on DM-8874; I could fix this if it's a trivial change)

        Show
        rowen Russell Owen added a comment - Yes it builds through pipe_tasks. Would you like me to build it any further? Also, does this update include a newer pybind11? When I build afw I'm seeing a warning I don't recall seeing before: python/lsst/afw/math/random.cc:96:16: warning: 'object' is deprecated: Use reinterpret_borrow<object>() or reinterpret_steal<object>() [-Wdeprecated-declarations] return py::object{PyBytes_FromStringAndSize(state.data(), state.size()), false}; ^ /Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pybind11/tickets.DM-8467-g939e5e0649/include/pybind11/pytypes.h:106:5: note: 'object' has been explicitly marked deprecated here object(handle h, bool is_borrowed) : handle(h) { if (is_borrowed) inc_ref(); } ^ (Note that I'm modifying afw/display on DM-8874 ; I could fix this if it's a trivial change)
        Hide
        pschella Pim Schellart [X] (Inactive) added a comment -

        No, this is the same pybind11 version. Will check and add separate ticket for cleanup.

        Show
        pschella Pim Schellart [X] (Inactive) added a comment - No, this is the same pybind11 version. Will check and add separate ticket for cleanup.

          People

          Assignee:
          pschella Pim Schellart [X] (Inactive)
          Reporter:
          pschella Pim Schellart [X] (Inactive)
          Reviewers:
          Russell Owen
          Watchers:
          Pim Schellart [X] (Inactive), Russell Owen
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved:

              CI Builds

              No builds found.