Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9258

Modify pybind11 sconsUtils to only prepend underscore if not already present

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      0.5
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Description

      Currently `scripts.pybind11` prepends an underscore to the source file base name to create the name of the generated module. This ticket aims to modify the script to only prepend the underscore if one is not already present in the source file name. This will allow seamless transition to the new convention from RFC-281.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          I want this for DM-8874 so I'll work on it immediately

          Show
          rowen Russell Owen added a comment - I want this for DM-8874 so I'll work on it immediately
          Hide
          jbosch Jim Bosch added a comment -

          Code looks fine. Two absolutely trivial comments you're free to ignore.

          Show
          jbosch Jim Bosch added a comment - Code looks fine. Two absolutely trivial comments you're free to ignore.
          Hide
          rowen Russell Owen added a comment -

          Thanks! I fixed the grammatical error. The other is a blank line that I added to address a flake8 warning and it will remain.

          Show
          rowen Russell Owen added a comment - Thanks! I fixed the grammatical error. The other is a blank line that I added to address a flake8 warning and it will remain.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.