# Modify pybind11 sconsUtils to only prepend underscore if not already present

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
• Story Points:
0.5
• Sprint:
• Team:

#### Description

Currently scripts.pybind11 prepends an underscore to the source file base name to create the name of the generated module. This ticket aims to modify the script to only prepend the underscore if one is not already present in the source file name. This will allow seamless transition to the new convention from RFC-281.

#### Activity

Hide
Russell Owen added a comment -

I want this for DM-8874 so I'll work on it immediately

Show
Russell Owen added a comment - I want this for DM-8874 so I'll work on it immediately
Hide
Jim Bosch added a comment -

Code looks fine. Two absolutely trivial comments you're free to ignore.

Show
Jim Bosch added a comment - Code looks fine. Two absolutely trivial comments you're free to ignore.
Hide
Russell Owen added a comment -

Thanks! I fixed the grammatical error. The other is a blank line that I added to address a flake8 warning and it will remain.

Show
Russell Owen added a comment - Thanks! I fixed the grammatical error. The other is a blank line that I added to address a flake8 warning and it will remain.

#### People

Assignee:
Russell Owen
Reporter:
Pim Schellart [X] (Inactive)
Reviewers:
Jim Bosch
Watchers:
Jim Bosch, Pim Schellart [X] (Inactive), Russell Owen