Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9276

Wrap obs_cfht with pybind11 instead of swig

    Details

    • Story Points:
      0.5
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Attachments

        Issue Links

          Activity

          Hide
          rowen Russell Owen added a comment -

          The usual fixes except one oddity: the unit test that needed updating was using e.message to print data about an exception, and that was not working. e.message is not Python 3 compliant and my fix is, but the fact that e.message was apparently working before pybind11 suggests our exception wrappers may be missing a little something. On the other hand, this is a trivial update and I would prefer to modernize our code rather than add legacy support to our wrappers.

          Show
          rowen Russell Owen added a comment - The usual fixes except one oddity: the unit test that needed updating was using e.message to print data about an exception, and that was not working. e.message is not Python 3 compliant and my fix is, but the fact that e.message was apparently working before pybind11 suggests our exception wrappers may be missing a little something. On the other hand, this is a trivial update and I would prefer to modernize our code rather than add legacy support to our wrappers.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Pretty trivial indeed
          One minor question on PR.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Pretty trivial indeed One minor question on PR.
          Hide
          rowen Russell Owen added a comment -

          Question answered (and I kept the code as is). Thanks for the quick review. Merged.

          Show
          rowen Russell Owen added a comment - Question answered (and I kept the code as is). Thanks for the quick review. Merged.

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel