Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9277

Wrap obs_decam with pybind11 instead of swig

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Attachments

        Issue Links

        blocks

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8467 Wrap lsst_distrib with pybind11

        • Done
        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9298 The stripMetadata argument of makeWcs doesn't work reliably

        • Done

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Only one change to one test required.

          However, I also took the time to modernize the Python code by using the usual from __future__ import... (and carefully checking existing division) and fixing flake8 warnings. In the process I discovered and reported DM-9294 which I did not fix because I'm not sure what a reasonable fix is (hard-code the values as constants? Read them from a data file?).

          Show
          rowen Russell Owen added a comment - - edited Only one change to one test required. However, I also took the time to modernize the Python code by using the usual from __future__ import... (and carefully checking existing division) and fixing flake8 warnings. In the process I discovered and reported DM-9294 which I did not fix because I'm not sure what a reasonable fix is (hard-code the values as constants? Read them from a data file?).
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          I spoke too soon...didn't have testdata_decam setup. There is more work to be done, including making afw.image.stripWcsKeywords unnecessary (as it should be, but a necessary feature is broken DM-9298) or available.

          Show
          rowen Russell Owen added a comment - - edited I spoke too soon...didn't have testdata_decam setup. There is more work to be done, including making afw.image.stripWcsKeywords unnecessary (as it should be, but a necessary feature is broken DM-9298 ) or available.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          This is a completely trivial change. However, it relies on a fix to afw (made on master as DM-9298 and rebased on tickets/DM-8467) and a fix to obs_decam (made on master as DM-9313).

          Show
          rowen Russell Owen added a comment - This is a completely trivial change. However, it relies on a fix to afw (made on master as DM-9298 and rebased on tickets/ DM-8467 ) and a fix to obs_decam (made on master as DM-9313 ).
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          Something seems wrong with the rebase.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Something seems wrong with the rebase.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Please ignore the afw pull request; the ticket DM-9277 was merely there to make Jenkins happy and will not be merged. The issue was solved by DM-9298 on master and rebased on DM-8467. There is nothing to see in DM-9277.

          The obs_decam pull request looks correct to me on github. It should be two small, obvious, changes in one file.

          Show
          rowen Russell Owen added a comment - Please ignore the afw pull request; the ticket DM-9277 was merely there to make Jenkins happy and will not be merged. The issue was solved by DM-9298 on master and rebased on DM-8467 . There is nothing to see in DM-9277 . The obs_decam pull request looks correct to me on github. It should be two small, obvious, changes in one file.
          Hide
          Permalink
          pschella Pim Schellart [X] (Inactive) added a comment -

          I had already looked at those changes. Seems fine.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - I had already looked at those changes. Seems fine.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Pim Schellart [X] (Inactive)
            Watchers:
            Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.