Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9294

makeCamera.py has undefined variables

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP F20-2 (July)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Function makeAmp in makeCamera.py has two undefined variables: nExtended and nOverclock.

        Attachments

          Issue Links

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Looks to me that makeCamera.py is not used anywhere and can be removed?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Looks to me that makeCamera.py is not used anywhere and can be removed?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            The relevant function was replaced with a runtime exception in DM-13339 over 2 years ago and no-one has noticed.

            Show
            tjenness Tim Jenness added a comment - The relevant function was replaced with a runtime exception in DM-13339 over 2 years ago and no-one has noticed.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Hey Meredith, do you have a moment to look at this please?

            As Tim points out, the code with undefined variables has been explicitly disabled for years, without causing any problems. I've further demonstrated that removing this whole file seems to have no impact on Jenkins, so let's just do that.

            PR: https://github.com/lsst/obs_decam/pull/163
            Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32295/display/redirect

            Show
            swinbank John Swinbank added a comment - Hey Meredith, do you have a moment to look at this please? As Tim points out, the code with undefined variables has been explicitly disabled for years, without causing any problems. I've further demonstrated that removing this whole file seems to have no impact on Jenkins, so let's just do that. PR: https://github.com/lsst/obs_decam/pull/163 Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32295/display/redirect
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Always great to see old things that aren't used actually go away! Thanks.

            Show
            mrawls Meredith Rawls added a comment - Always great to see old things that aren't used actually go away! Thanks.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thank you!

            Show
            swinbank John Swinbank added a comment - Thank you!

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              rowen Russell Owen
              Reviewers:
              Meredith Rawls
              Watchers:
              Hsin-Fang Chiang, John Swinbank, Meredith Rawls, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.