Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Alert Production S17 - 2
-
Team:Alert Production
Description
The function afw::image::makeWcs(metadata, stripMetadata with its second argument true does not strip metadata if certain values are present because those values induce a deep copy of the metadata, and the keywords are stripped from the copy.
Attachments
Issue Links
Activity
The whitespace changes should probably go in a separate commit, but apart from that this looks fine. I think the whole approach in this function should be revised (get rid of the _metadata vs metadata distinction), but your change gets the job done.
Paul Price
added a comment - The whitespace changes should probably go in a separate commit, but apart from that this looks fine. I think the whole approach in this function should be revised (get rid of the _metadata vs metadata distinction), but your change gets the job done. Paul Price I agree with everything you said. I did break the commit into two before merging.
Trivial change. It passes Jenkins and can be used to eliminate the need to call afw::image::detail::stripWcsMetadata in obs_decam.
I restrained myself from improving the call signature of stripWcsMetadata.