Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9298

The stripMetadata argument of makeWcs doesn't work reliably

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Description

      The function afw::image::makeWcs(metadata, stripMetadata with its second argument true does not strip metadata if certain values are present because those values induce a deep copy of the metadata, and the keywords are stripped from the copy.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Trivial change. It passes Jenkins and can be used to eliminate the need to call afw::image::detail::stripWcsMetadata in obs_decam.

            I restrained myself from improving the call signature of stripWcsMetadata.

            Show
            rowen Russell Owen added a comment - Trivial change. It passes Jenkins and can be used to eliminate the need to call afw::image::detail::stripWcsMetadata in obs_decam. I restrained myself from improving the call signature of stripWcsMetadata .
            Hide
            price Paul Price added a comment -

            The whitespace changes should probably go in a separate commit, but apart from that this looks fine. I think the whole approach in this function should be revised (get rid of the _metadata vs metadata distinction), but your change gets the job done.

            Show
            price Paul Price added a comment - The whitespace changes should probably go in a separate commit, but apart from that this looks fine. I think the whole approach in this function should be revised (get rid of the _metadata vs metadata distinction), but your change gets the job done.
            Hide
            rowen Russell Owen added a comment -

            Paul Price I agree with everything you said. I did break the commit into two before merging.

            Show
            rowen Russell Owen added a comment - Paul Price I agree with everything you said. I did break the commit into two before merging.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Paul Price
              Watchers:
              Jim Bosch, Paul Price, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.