Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9316

meas_base tests broken with NumPy 1.12

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      meas_base's tests/testVariance.py contains the line:

      var.getArray()[bad, :] = float("nan")

      Where bad is 54.0.

      As of NumPy 1.12, this will throw an IndexError and the tests (obviously) fail.

      Should be an easy fix.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-9724 Error installing sims_catalog

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8032 Tighten testProcessCcd thresholds once background model is fixed

          • Done

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Hey David Reiss, do you have time to review this? It should be pretty trivial!

            Show
            swinbank John Swinbank added a comment - Hey David Reiss , do you have time to review this? It should be pretty trivial!
            Hide
            Permalink
            rowen Russell Owen added a comment -

            My unsolicited comment is that these changes all look good, but I suggest using int(py+psfh) instead of int(py)+psfh in ip_diffim. (If David Reiss is comfortable with it, this could be deemed a review).

            Show
            rowen Russell Owen added a comment - My unsolicited comment is that these changes all look good, but I suggest using int(py+psfh) instead of int(py)+psfh in ip_diffim. (If David Reiss is comfortable with it, this could be deemed a review).
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I've tweaked the way the casting is done in ip_diffim based on the suggestion from Russell Owen and further comments from Tim Jenness. Not quite in the way either of them suggested, but I hope it's good enough to keep them happy!

            I'll wait for David to chime in on whether he thinks this has had enough reviewing before I do anything else.

            Show
            swinbank John Swinbank added a comment - I've tweaked the way the casting is done in ip_diffim based on the suggestion from Russell Owen and further comments from Tim Jenness . Not quite in the way either of them suggested, but I hope it's good enough to keep them happy! I'll wait for David to chime in on whether he thinks this has had enough reviewing before I do anything else.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Looks good to me and you chose the casting that I would have preferred. So call it reviewed.
            Thanks also to Russell Owen and Tim Jenness.

            Show
            reiss David Reiss added a comment - Looks good to me and you chose the casting that I would have preferred. So call it reviewed. Thanks also to Russell Owen and Tim Jenness .
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks, all. Merged.

            Show
            swinbank John Swinbank added a comment - Thanks, all. Merged.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              David Reiss
              Watchers:
              David Reiss, John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.