# meas_base tests broken with NumPy 1.12

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
1
• Sprint:
DRP S17-3
• Team:
Data Release Production

#### Description

meas_base's tests/testVariance.py contains the line:

 var.getArray()[bad, :] = float("nan") 

As of NumPy 1.12, this will throw an IndexError and the tests (obviously) fail.

Should be an easy fix.

#### Activity

Hide
John Swinbank added a comment -

Hey David Reiss, do you have time to review this? It should be pretty trivial!

Show
John Swinbank added a comment - Hey David Reiss , do you have time to review this? It should be pretty trivial!
Hide
Russell Owen added a comment -

My unsolicited comment is that these changes all look good, but I suggest using int(py+psfh) instead of int(py)+psfh in ip_diffim. (If David Reiss is comfortable with it, this could be deemed a review).

Show
Russell Owen added a comment - My unsolicited comment is that these changes all look good, but I suggest using int(py+psfh) instead of int(py)+psfh in ip_diffim. (If David Reiss is comfortable with it, this could be deemed a review).
Hide
John Swinbank added a comment -

I've tweaked the way the casting is done in ip_diffim based on the suggestion from Russell Owen and further comments from Tim Jenness. Not quite in the way either of them suggested, but I hope it's good enough to keep them happy!

I'll wait for David to chime in on whether he thinks this has had enough reviewing before I do anything else.

Show
John Swinbank added a comment - I've tweaked the way the casting is done in ip_diffim based on the suggestion from Russell Owen and further comments from Tim Jenness . Not quite in the way either of them suggested, but I hope it's good enough to keep them happy! I'll wait for David to chime in on whether he thinks this has had enough reviewing before I do anything else.
Hide
David Reiss added a comment -

Looks good to me and you chose the casting that I would have preferred. So call it reviewed.
Thanks also to Russell Owen and Tim Jenness.

Show
David Reiss added a comment - Looks good to me and you chose the casting that I would have preferred. So call it reviewed. Thanks also to Russell Owen and Tim Jenness .
Hide
John Swinbank added a comment -

Thanks, all. Merged.

Show
John Swinbank added a comment - Thanks, all. Merged.

#### People

Assignee:
John Swinbank
Reporter:
John Swinbank
Reviewers:
David Reiss
Watchers:
David Reiss, John Swinbank, Russell Owen