Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9330

Uniqueness of metric name


    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:


      The issue was raised by Jonathan Sick during the code review of DM-9034 and led to this ticket.

               if vdrp_measurement_doc['value'] is None:
      +        if vdrp_measurement_doc['metric']['name'] not in registered_metrics:
      +            metrics.append(shim_metric_definition(vdrp_measurement_doc))

      Is it possible for a metric to appear multiple times in this list? Like, if there's multiple AM1 measurements in different bands, or multiple measurements against different specifications of a metric, then couldn't we have duplicates here?

      That's a good point. In this implementation the metric name is unique so if there is already an AM1 registered it would not pick another AM1 with a different specification.

      I see the problem when a metric, say AD1, depends on another metric specification, in this case AF1. We end up with three measurements of AD1 for each AF1 specification level, right?

      I think if a metric has a different parameter or specification it should be named differently, so that we can identify each metric uniquely by its name, or perhaps have another mechanism like a composite primary key based on the metric name and specification? we should think on how to display the metric measurements in this situation too.



          afausti Angelo Fausti created issue -
          afausti Angelo Fausti made changes -
          Field Original Value New Value
          Epic Link DM-8477 [ 28109 ]
          frossie Frossie Economou made changes -
          Epic Link DM-8477 [ 28109 ] DM-5504 [ 23337 ]
          afausti Angelo Fausti made changes -
          Resolution Done [ 10000 ]
          Status To Do [ 10001 ] Won't Fix [ 10405 ]


            • Assignee:
              afausti Angelo Fausti
              afausti Angelo Fausti
              Angelo Fausti, Frossie Economou
            • Votes:
              0 Vote for this issue
              2 Start watching this issue


              • Created:

                Summary Panel