Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9353

Update configuration for HSC calib construction

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None

      Description

      DM-9186 changed how the ISR configuration is set, but the configuration for calib construction wasn't updated to match.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Lauren MacArthur, would you please look over this simple change?

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-9353=) $ git sub
          commit 7edf32472901cafb372dbbc00b16afec8726a2cf
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Thu Feb 9 13:07:11 2017 -0500
           
              config: update ISR for calib construction
              
              DM-9353 changed how ISR was configured for HSC. This patch
              adapts the calib construction configurations to that change.
           
           config/hsc/bias.py   | 4 +++-
           config/hsc/dark.py   | 4 +++-
           config/hsc/flat.py   | 4 +++-
           config/hsc/fringe.py | 4 +++-
           4 files changed, 12 insertions(+), 4 deletions(-)
          

          Show
          price Paul Price added a comment - Lauren MacArthur , would you please look over this simple change? price@price-laptop:~/LSST/obs/subaru (tickets/DM-9353=) $ git sub commit 7edf32472901cafb372dbbc00b16afec8726a2cf Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 9 13:07:11 2017 -0500   config: update ISR for calib construction DM-9353 changed how ISR was configured for HSC. This patch adapts the calib construction configurations to that change.   config/hsc/bias.py | 4 +++- config/hsc/dark.py | 4 +++- config/hsc/flat.py | 4 +++- config/hsc/fringe.py | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-)
          Hide
          lauren Lauren MacArthur added a comment -

          Looks good. I suppose there is no context for wanting to use the hscIsr.py script with data from the other Subaru cameras (may be a question for Joshua Meyers)?

          Show
          lauren Lauren MacArthur added a comment - Looks good. I suppose there is no context for wanting to use the hscIsr.py script with data from the other Subaru cameras (may be a question for Joshua Meyers )?
          Hide
          jmeyers314 Joshua Meyers added a comment -

          I have no plans for other cameras.

          That said, maybe `hscIsr.py` would work on them anyway (since it just calls down to `SubaruIsrTask`)? If so, then consider renaming to just `subaruIsr.py`?

          Show
          jmeyers314 Joshua Meyers added a comment - I have no plans for other cameras. That said, maybe `hscIsr.py` would work on them anyway (since it just calls down to `SubaruIsrTask`)? If so, then consider renaming to just `subaruIsr.py`?
          Hide
          jmeyers314 Joshua Meyers added a comment -

          Ugghh.. I can't seem to keep my code quoting syntaxes straight...

          Show
          jmeyers314 Joshua Meyers added a comment - Ugghh.. I can't seem to keep my code quoting syntaxes straight...
          Hide
          lauren Lauren MacArthur added a comment -

          Yep, that's what I was thinking.

          (btw, you can edit your posts )

          Show
          lauren Lauren MacArthur added a comment - Yep, that's what I was thinking. (btw, you can edit your posts )
          Hide
          swinbank John Swinbank added a comment -

          Typo in commit message – DM-9353 should be DM-9186?

          Show
          swinbank John Swinbank added a comment - Typo in commit message – DM-9353 should be DM-9186 ?
          Hide
          price Paul Price added a comment -

          Thanks, all.

          Fixed the commit message and merged to master.

          Show
          price Paul Price added a comment - Thanks, all. Fixed the commit message and merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Lauren MacArthur
              Watchers:
              John Swinbank, Joshua Meyers, Lauren MacArthur, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel