Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9357

Robustify pybind11 reference and pointer return types

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently pybind11 defaults to py::return_value_policy::copy or (py::return_value_policy::take_ownership) for (const) references (and pointers) respectively.
      It would be better if it would require an explicit return_value_policy to be specified instead.

      Investigate this further and potentially push changes upstream.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Is this essential to the immediate pybind porting work? If not, let's move it to the DM-9155 epic.

            Show
            swinbank John Swinbank added a comment - Is this essential to the immediate pybind porting work? If not, let's move it to the DM-9155 epic.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            That depends on how Jim Bosch feels about it. We can certainly complete the port without it, but it may help prevent issues later.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - That depends on how Jim Bosch feels about it. We can certainly complete the port without it, but it may help prevent issues later.
            Hide
            swinbank John Swinbank added a comment -

            We can certainly complete the port without it

            That sounds like the key information. I'll move it to DM-9155.

            Show
            swinbank John Swinbank added a comment - We can certainly complete the port without it That sounds like the key information. I'll move it to DM-9155 .
            Hide
            swinbank John Swinbank added a comment -

            3.5 years later, we haven't investigated, it hasn't caused any problems, and I don't think we have spare effort to push changes upstream. Won't Fix.

            Show
            swinbank John Swinbank added a comment - 3.5 years later, we haven't investigated, it hasn't caused any problems, and I don't think we have spare effort to push changes upstream. Won't Fix.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.