Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9369

Change from __getstate__/__setstate__ to __reduce__ for pickling support in pybind11

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      We have found pickling support more reliable using __reduce__ than __getstate__/__setstate__. There are still eight instances of the latter that should be changed, one each in dateTime.cc and propertyList.cc and various in python files.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Do we need this before merge to master? Or can this be part of cleanup?

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Do we need this before merge to master? Or can this be part of cleanup?
            Hide
            jbosch Jim Bosch added a comment -

            Probably cleanup unless we still have unresolved pickling problems. I suppose we can fix those case-by-case, which is not what this issue is about.

            Show
            jbosch Jim Bosch added a comment - Probably cleanup unless we still have unresolved pickling problems. I suppose we can fix those case-by-case, which is not what this issue is about.
            Hide
            swinbank John Swinbank added a comment -

            Looks like this was addressed on DM-14828 as far as propertyList.cc is concerned. A brief search turned up no (historical or current) use of __getstate__/__setstate__ in dateTime.cc (did I miss it?). Not clear where the other six instances are (in unspecified Python code; I didn't think it was worth spending long grepping). Given that this doesn't seem to be actually causing any reliability problems, I'm inclined to close as “won't fix”.

            Show
            swinbank John Swinbank added a comment - Looks like this was addressed on DM-14828 as far as propertyList.cc is concerned. A brief search turned up no (historical or current) use of __getstate__ / __setstate__ in dateTime.cc (did I miss it?). Not clear where the other six instances are (in unspecified Python code; I didn't think it was worth spending long grepping). Given that this doesn't seem to be actually causing any reliability problems, I'm inclined to close as “won't fix”.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.