Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9384

Fix wrapped constructor for StatisticsControl

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      The constructor for lsst::afw::math::StatisticsControl has some arguments with default values, but the pybind11 wrapper omits them and only provides a default constructor. This breaks some existing code. I propose to wrap the constructor as written (which will be quite pleasant to use with named arguments) rather than fix the existing Python code that relies on being able to specify arguments to the constructor.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -

          Trivial addition, but I also took the opportunity to clean up statistics.cc in a separate commit.

          Show
          rowen Russell Owen added a comment - Trivial addition, but I also took the opportunity to clean up statistics.cc in a separate commit.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good. Although I think I have an alternative fix for it on DM-9156 ;(

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good. Although I think I have an alternative fix for it on DM-9156 ;(
          Hide
          rowen Russell Owen added a comment -

          Merged. Sorry about the duplicate work.

          Show
          rowen Russell Owen added a comment - Merged. Sorry about the duplicate work.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Pim Schellart [X] (Inactive)
            Watchers:
            Pim Schellart [X] (Inactive), Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.