Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Alert Production S17 - 2
-
Team:Alert Production
Description
The constructor for lsst::afw::math::StatisticsControl has some arguments with default values, but the pybind11 wrapper omits them and only provides a default constructor. This breaks some existing code. I propose to wrap the constructor as written (which will be quite pleasant to use with named arguments) rather than fix the existing Python code that relies on being able to specify arguments to the constructor.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Pim Schellart [ pschella ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Looks good. Although I think I have an alternative fix for it on DM-9156 ;(
Pim Schellart [X] (Inactive)
added a comment - Looks good. Although I think I have an alternative fix for it on DM-9156 ;( Pim Schellart [X] (Inactive)
made changes -
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Merged. Sorry about the duplicate work.
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Trivial addition, but I also took the opportunity to clean up statistics.cc in a separate commit.