Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9386

IpacTableIpacTableFromSource returns one row less if there is no terminating new line in the table

    XMLWordPrintable

Details

    • 2
    • SUIT Sprint 2017-2
    • Science User Interface

    Description

      IpacTableFromSource processor does not return the last row of the attached table. (This table does not have the newline after the last row.)

      To test, put the attached a.tbl to /hydra/workarea/firefly/temp_files and the attached test.html into /hydra/server/tomcat/webapps/firefly/demo. Use http://localhost:8080/firefly/demo/test.html to see the table.

      • Notice the number of rows is 157, the last row seems to be lost.
      • Sort on any column. Notice the number of rows is 158.

      We noticed this problem in LC phase folded table (the one that is being uploaded to the server). The attached file is a copy of the uploaded phase-folded table.

      Attachments

        1. a.tbl
          48 kB
        2. test.html
          1 kB

        Activity

          This affects also Gator/Atlas when dong multiple target search uploading a table with this characteristic.

          ejoliet Emmanuel Joliet added a comment - This affects also Gator/Atlas when dong multiple target search uploading a table with this characteristic.

          This ticket was fixed by DM-7971, https://github.com/Caltech-IPAC/firefly/pull/300.
          I tested it, the problem is no longer there after Loi's ticket was merged.

          tatianag Tatiana Goldina added a comment - This ticket was fixed by DM-7971 , https://github.com/Caltech-IPAC/firefly/pull/300 . I tested it, the problem is no longer there after Loi's ticket was merged.

          The last row missing bug is fixed in DM-7971 In IpacTableUtil and IpacTableParser.

          The class IpacTableFromSource is just a caller. Three public/protected methods take TableServerRequest and return either File or unique id. Making a test unit for this class doesn't gain too much. Skip it for now.

          ymei Yi Mei [X] (Inactive) added a comment - The last row missing bug is fixed in DM-7971 In IpacTableUtil and IpacTableParser. The class IpacTableFromSource is just a caller. Three public/protected methods take TableServerRequest and return either File or unique id. Making a test unit for this class doesn't gain too much. Skip it for now.

          People

            ymei Yi Mei [X] (Inactive)
            tatianag Tatiana Goldina
            Emmanuel Joliet, Tatiana Goldina, Xiuqin Wu [X] (Inactive), Yi Mei [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.