Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9386

IpacTableIpacTableFromSource returns one row less if there is no terminating new line in the table

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      SUIT Sprint 2017-2
    • Team:
      Science User Interface

      Description

      IpacTableFromSource processor does not return the last row of the attached table. (This table does not have the newline after the last row.)

      To test, put the attached a.tbl to /hydra/workarea/firefly/temp_files and the attached test.html into /hydra/server/tomcat/webapps/firefly/demo. Use http://localhost:8080/firefly/demo/test.html to see the table.

      • Notice the number of rows is 157, the last row seems to be lost.
      • Sort on any column. Notice the number of rows is 158.

      We noticed this problem in LC phase folded table (the one that is being uploaded to the server). The attached file is a copy of the uploaded phase-folded table.

        Attachments

        1. a.tbl
          48 kB
        2. test.html
          1 kB

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          tatianag Tatiana Goldina created issue -
          tatianag Tatiana Goldina made changes -
          Field Original Value New Value
          Epic Link DM-8350 [ 27954 ]
          ejoliet Emmanuel Joliet made changes -
          Labels LC pdac FireflyCCB IRSA LC pdac
          Hide
          Permalink
          ejoliet Emmanuel Joliet added a comment -

          This affects also Gator/Atlas when dong multiple target search uploading a table with this characteristic.

          Show
          ejoliet Emmanuel Joliet added a comment - This affects also Gator/Atlas when dong multiple target search uploading a table with this characteristic.
          xiuqin Xiuqin Wu [X] (Inactive) made changes -
          Epic Link DM-8350 [ 27954 ] DM-8203 [ 27715 ]
          xiuqin Xiuqin Wu [X] (Inactive) made changes -
          Assignee Loi Ly [ loi ] Yi Mei [ ymei ]
          xiuqin Xiuqin Wu [X] (Inactive) made changes -
          Story Points 6
          xiuqin Xiuqin Wu [X] (Inactive) made changes -
          Sprint SUIT Sprint 2017-2 [ 309 ]
          xiuqin Xiuqin Wu [X] (Inactive) made changes -
          Watchers Emmanuel Joliet, Tatiana Goldina [ Emmanuel Joliet, Tatiana Goldina ] Emmanuel Joliet, Tatiana Goldina, Xiuqin Wu [ Emmanuel Joliet, Tatiana Goldina, Xiuqin Wu ]
          Hide
          Permalink
          tatianag Tatiana Goldina added a comment -

          This ticket was fixed by DM-7971, https://github.com/Caltech-IPAC/firefly/pull/300.
          I tested it, the problem is no longer there after Loi's ticket was merged.

          Show
          tatianag Tatiana Goldina added a comment - This ticket was fixed by DM-7971 , https://github.com/Caltech-IPAC/firefly/pull/300 . I tested it, the problem is no longer there after Loi's ticket was merged.
          ejoliet Emmanuel Joliet made changes -
          Labels FireflyCCB IRSA LC pdac FireflyCCB IRSA LC pdac rel_irsa_201702
          ymei Yi Mei [X] (Inactive) made changes -
          Story Points 6 2
          Hide
          Permalink
          ymei Yi Mei [X] (Inactive) added a comment -

          The last row missing bug is fixed in DM-7971 In IpacTableUtil and IpacTableParser.

          The class IpacTableFromSource is just a caller. Three public/protected methods take TableServerRequest and return either File or unique id. Making a test unit for this class doesn't gain too much. Skip it for now.

          Show
          ymei Yi Mei [X] (Inactive) added a comment - The last row missing bug is fixed in DM-7971 In IpacTableUtil and IpacTableParser. The class IpacTableFromSource is just a caller. Three public/protected methods take TableServerRequest and return either File or unique id. Making a test unit for this class doesn't gain too much. Skip it for now.
          ymei Yi Mei [X] (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status To Do [ 10001 ] Done [ 10002 ]

            People

            Assignee:
            ymei Yi Mei [X] (Inactive)
            Reporter:
            tatianag Tatiana Goldina
            Watchers:
            Emmanuel Joliet, Tatiana Goldina, Xiuqin Wu [X] (Inactive), Yi Mei [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.