Paul Price added a comment - 14/Feb/17 4:54 PM Lauren MacArthur , would you please review this? pprice@lsst-dev01:/scratch/pprice/madcash/obs_subaru[tickets/DM-9423] $ git sub commit 0caca62c7890b1ee114f27ce82bce0627373c277 Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 14 17:47:51 2017 -0600   HscMapper: support registry lookups for mosaic The 'wcs' dataset is used as the base dataset for MosaicTask, but it wasn't working with something like "--id field=FOO filter=BAR". This patch fixes the lookups for the 'wcs' and 'fcr' datasets.   policy/HscMapper.paf | 2 -- python/lsst/obs/hsc/hscMapper.py | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)     pprice@lsst-dev01:/scratch/pprice/madcash/meas_mosaic[tickets/DM-9423] $ git sub commit dfe98520330e7f0a6e7895caac43aea093f088d6 Author: Paul Price <price@astro.princeton.edu> Date: Mon May 23 15:06:07 2016 -0400   MosaicTask: allow data from multiple filters, if configured We want to combine data from the HSC-I and HSC-I2 filters, if and only if the 'allowMixedFilters' config parameter is set. Cherry-picked from HSC-1398, and adapted to the LSST stack.   python/lsst/meas/mosaic/mosaicTask.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)   commit 1e60df2937a48e753aa7e6eaf2979aae084d3c60 Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 14 17:51:03 2017 -0600   make astrometry loader configurable This allows use of the LSST format for astrometry/photometry reference catalog.   python/lsst/meas/mosaic/mosaicTask.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Lauren MacArthur added a comment - 16/Feb/17 11:54 AM Looks good. Two minor comments about your commit messages: The 'wcs' dataset is used as the base dataset for MosaicTask Is there a reason 'wcs' is given special mention over 'fcr'? We want to combine data from the HSC-I and HSC-I2 filters Really you want to be able to combine any arbitrary combination (well, not really "arbitrary", but you know what I mean!) It may be worth updating the ticket description to indicate the update to allow for use of the LSST format for astrometry/photometry reference catalog. Otherwise, good to go!

Paul Price added a comment - 16/Feb/17 12:20 PM The wcs dataset is the base dataset for MosaicTask because it is used by the ArgumentParser . Yes, we want to be able to combine data from different filters. At the moment we don't have another mechanism for dealing with the HSC-I+HSC-I2 and HSC-R+HSC-R2 filters.

Paul Price added a comment - 16/Feb/17 12:35 PM Updated the commit message about combining data to make it clear that HSC-I+HSC-I2 is an example. Merged to master Thanks Lauren MacArthur !