Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9432

Remove obsolete casts and vectors from Python

    Details

      Attachments

        Issue Links

          Activity

          Hide
          rowen Russell Owen added a comment - - edited

          In most cases this updates code that not unit tested, including examples, display code and a bit of other library code.

          In obs_sdss I fixed a problem that prevented lsst_dm_stack_demo from running under python 2 (which I would have caught as part of DM-9429 if Jenkins could have been used to run the stack demo at that point, as it now can).

          Show
          rowen Russell Owen added a comment - - edited In most cases this updates code that not unit tested, including examples, display code and a bit of other library code. In obs_sdss I fixed a problem that prevented lsst_dm_stack_demo from running under python 2 (which I would have caught as part of DM-9429 if Jenkins could have been used to run the stack demo at that point, as it now can).
          Hide
          rowen Russell Owen added a comment -

          I encourage the reviewer to start with obs_sdss (so the demo can run) and afw (because the changes are innocuous and so many packages rely on afw).

          Show
          rowen Russell Owen added a comment - I encourage the reviewer to start with obs_sdss (so the demo can run) and afw (because the changes are innocuous and so many packages rely on afw).
          Hide
          krzys Krzysztof Findeisen added a comment -

          All changes approved. Some minor comments on individual packages' pull requests.

          Show
          krzys Krzysztof Findeisen added a comment - All changes approved. Some minor comments on individual packages' pull requests.
          Hide
          krzys Krzysztof Findeisen added a comment -

          One meta-comment: please try to follow stack conventions on PR names in the future, https://developer.lsst.io/processes/workflow.html#make-a-pull-request. The PR names for this issue were quite diverse.

          Show
          krzys Krzysztof Findeisen added a comment - One meta-comment: please try to follow stack conventions on PR names in the future, https://developer.lsst.io/processes/workflow.html#make-a-pull-request . The PR names for this issue were quite diverse.
          Hide
          rowen Russell Owen added a comment -

          Thank you for the quick and helpful review. All changes merged (after rebasing one set of changes to clarify why the names of files in examples were changed).

          Show
          rowen Russell Owen added a comment - Thank you for the quick and helpful review. All changes merged (after rebasing one set of changes to clarify why the names of files in examples were changed).
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          I'm guilty of that as well. I forgot we had conventions for these and always just used whatever github came up with.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - I'm guilty of that as well. I forgot we had conventions for these and always just used whatever github came up with.
          Hide
          rowen Russell Owen added a comment -

          I had no idea we even had conventions for PR names. I'll read the link.

          I added DM-9436 to handle making afw's `spatialCellExample.py` run again. It is lower priority and needs more work than I felt was justified in this ticket.

          At this point we can build all of lsst_distrib in Jenkins and the stack demo will run. Note that meas_multifit is not yet wrapped, so the build only works due to a hack in obs_subaru to not pull in that package. Also there are temporary hack to disable ctrl_events and ctrl_orca, both of which will be retired very shortly and so were not worth converting to pybind11.

          Show
          rowen Russell Owen added a comment - I had no idea we even had conventions for PR names. I'll read the link. I added DM-9436 to handle making afw's `spatialCellExample.py` run again. It is lower priority and needs more work than I felt was justified in this ticket. At this point we can build all of lsst_distrib in Jenkins and the stack demo will run. Note that meas_multifit is not yet wrapped, so the build only works due to a hack in obs_subaru to not pull in that package. Also there are temporary hack to disable ctrl_events and ctrl_orca , both of which will be retired very shortly and so were not worth converting to pybind11.

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel