Fix Version/s: None
Sprint:Alert Production S17 - 2
Our final pybind11 coding conventions dictate that the wrapper library name should match the source code name. However, all of our existing pybind11 wrappers assume that the library name will always start with an underscore (whether the source file name does or not).
I will add a new flag addUnderscore=True to the pybind11 function. New code should specify this flag as False. Old code will continue to work unchanged.
|Field||Original Value||New Value|
|Reviewers||Pim Schellart [ pschella ]|
|Status||To Do [ 10001 ]||In Review [ 10004 ]|
Looks ok, although perhaps simply adding a second version of the method (with a different name) would be easier. It only has to live for a few weeks.
|Status||In Review [ 10004 ]||Reviewed [ 10101 ]|
I thought of using a different name, but could not think of one I was happy with. The current name is really nice. I'm not entirely convinced that we will manage a full cleanup pass in a few weeks, though I'd be happy if it did occur.
|Resolution||Done [ 10000 ]|
|Status||Reviewed [ 10101 ]||Done [ 10002 ]|
I tested it using sphgeom and it works. Is this solution satisfactory?