Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9501

subaru config/Mosaic.py has bad filterMap names

    Details

      Description

      obs_subaru/config/Mosaic.py lines 8 and 9 should have loadAstrom.filterMap instead of astrom.filterMap. Without this, those refcats won't work by default.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.

            Show
            price Paul Price added a comment - What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.
            Hide
            lauren Lauren MacArthur added a comment -

            This would only be an issue if you were using a non-ps1 ref cat.

            Show
            lauren Lauren MacArthur added a comment - This would only be an issue if you were using a non-ps1 ref cat.
            Hide
            lauren Lauren MacArthur added a comment - - edited

            Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)

            Show
            lauren Lauren MacArthur added a comment - - edited Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)
            Hide
            tmorton Tim Morton added a comment -

            Yeah, looking to try to confirm now.

            Show
            tmorton Tim Morton added a comment - Yeah, looking to try to confirm now.
            Hide
            tmorton Tim Morton added a comment -

            OK, I see that based on the changes Paul Price has made to the config file (https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699) this bug is no longer relevant.

            Show
            tmorton Tim Morton added a comment - OK, I see that based on the changes Paul Price has made to the config file ( https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699 ) this bug is no longer relevant.

              People

              • Assignee:
                tmorton Tim Morton
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Lauren MacArthur
                Watchers:
                John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Simon Krughoff, Tim Morton
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel