# subaru config/Mosaic.py has bad filterMap names

XMLWordPrintable

## Details

• Type: Bug
• Status: Won't Fix
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
0.5
• Sprint:
DRP S17-4
• Team:
Data Release Production

## Description

obs_subaru/config/Mosaic.py lines 8 and 9 should have loadAstrom.filterMap instead of astrom.filterMap. Without this, those refcats won't work by default.

## Activity

Hide
Paul Price added a comment -

Try DM-9423. If that doesn't work, maybe DM-9438.

Show
Paul Price added a comment - Try DM-9423 . If that doesn't work, maybe DM-9438 .
Hide
John Parejko added a comment -

I discovered this when attempting to process validation_data_hsc (a version I reprocessed with a recent stack) with meas_mosaic via the following command:

 mosaic.py /data/validate/validation_data_hsc/DATA/rerun/20160805 --output hsc_output --id visit=903982^904006^904828^904846 tract=0 --diagnostics --diagDir hsc_output 

validation_data_hsc uses a.net sdss data, which is why it triggered the above.

Show
John Parejko added a comment - I discovered this when attempting to process validation_data_hsc (a version I reprocessed with a recent stack) with meas_mosaic via the following command: mosaic.py /data/validate/validation_data_hsc/DATA/rerun/20160805 --output hsc_output --id visit=903982^904006^904828^904846 tract=0 --diagnostics --diagDir hsc_output validation_data_hsc uses a.net sdss data, which is why it triggered the above.
Hide
Lauren MacArthur added a comment - - edited

Paul Price, I think the following in the DM-9438 ticket branch still inherits the bug:
https://github.com/lsst/obs_subaru/commit/316a9d88e0927eb8d6a9255587bb299c350eae8c

?

Show
Lauren MacArthur added a comment - - edited Paul Price , I think the following in the DM-9438 ticket branch still inherits the bug: https://github.com/lsst/obs_subaru/commit/316a9d88e0927eb8d6a9255587bb299c350eae8c --> astrom.filterMap should be loadAstrom.filterMap ?
Hide
Paul Price added a comment -

You're right.

Show
Paul Price added a comment - You're right.
Hide
Paul Price added a comment -

What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.

Show
Paul Price added a comment - What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.
Hide
Lauren MacArthur added a comment -

This would only be an issue if you were using a non-ps1 ref cat.

Show
Lauren MacArthur added a comment - This would only be an issue if you were using a non-ps1 ref cat.
Hide
Lauren MacArthur added a comment - - edited

Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)

Show
Lauren MacArthur added a comment - - edited Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)
Hide
Tim Morton added a comment -

Yeah, looking to try to confirm now.

Show
Tim Morton added a comment - Yeah, looking to try to confirm now.
Hide
Tim Morton added a comment -

OK, I see that based on the changes Paul Price has made to the config file (https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699) this bug is no longer relevant.

Show
Tim Morton added a comment - OK, I see that based on the changes Paul Price has made to the config file ( https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699 ) this bug is no longer relevant.

## People

• Assignee:
Tim Morton
Reporter:
John Parejko
Reviewers:
Lauren MacArthur
Watchers:
John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Simon Krughoff, Tim Morton