Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9501

subaru config/Mosaic.py has bad filterMap names

    Details

      Description

      obs_subaru/config/Mosaic.py lines 8 and 9 should have loadAstrom.filterMap instead of astrom.filterMap. Without this, those refcats won't work by default.

        Attachments

          Issue Links

            Activity

            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to DM-9194 [ DM-9194 ]
            lauren Lauren MacArthur made changes -
            Watchers John Parejko, John Swinbank, Lauren MacArthur, Simon Krughoff [ John Parejko, John Swinbank, Lauren MacArthur, Simon Krughoff ] John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Simon Krughoff [ John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Simon Krughoff ]
            swinbank John Swinbank made changes -
            Epic Link DM-8306 [ 27828 ]
            Hide
            price Paul Price added a comment -

            Try DM-9423. If that doesn't work, maybe DM-9438.

            Show
            price Paul Price added a comment - Try DM-9423 . If that doesn't work, maybe DM-9438 .
            Hide
            Parejkoj John Parejko added a comment -

            I discovered this when attempting to process validation_data_hsc (a version I reprocessed with a recent stack) with meas_mosaic via the following command:

            mosaic.py /data/validate/validation_data_hsc/DATA/rerun/20160805 --output hsc_output --id visit=903982^904006^904828^904846 tract=0 --diagnostics --diagDir hsc_output
            

            validation_data_hsc uses a.net sdss data, which is why it triggered the above.

            Show
            Parejkoj John Parejko added a comment - I discovered this when attempting to process validation_data_hsc (a version I reprocessed with a recent stack) with meas_mosaic via the following command: mosaic.py /data/validate/validation_data_hsc/DATA/rerun/20160805 --output hsc_output --id visit=903982^904006^904828^904846 tract=0 --diagnostics --diagDir hsc_output validation_data_hsc uses a.net sdss data, which is why it triggered the above.
            Hide
            lauren Lauren MacArthur added a comment - - edited

            Paul Price, I think the following in the DM-9438 ticket branch still inherits the bug:
            https://github.com/lsst/obs_subaru/commit/316a9d88e0927eb8d6a9255587bb299c350eae8c

            --> astrom.filterMap should be loadAstrom.filterMap
            ?

            Show
            lauren Lauren MacArthur added a comment - - edited Paul Price , I think the following in the DM-9438 ticket branch still inherits the bug: https://github.com/lsst/obs_subaru/commit/316a9d88e0927eb8d6a9255587bb299c350eae8c --> astrom.filterMap should be loadAstrom.filterMap ?
            Hide
            price Paul Price added a comment -

            You're right.

            Show
            price Paul Price added a comment - You're right.
            lauren Lauren MacArthur made changes -
            Assignee Tim Morton [ tmorton ]
            swinbank John Swinbank made changes -
            Sprint DRP S17-4 [ 363 ]
            tmorton Tim Morton made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tmorton Tim Morton made changes -
            Reviewers Lauren MacArthur [ lauren ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            price Paul Price added a comment -

            What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.

            Show
            price Paul Price added a comment - What's the status of this? I'm happily running meas_mosaic on HSC data, so if this hasn't merged already it may no longer be necessary.
            Hide
            lauren Lauren MacArthur added a comment -

            This would only be an issue if you were using a non-ps1 ref cat.

            Show
            lauren Lauren MacArthur added a comment - This would only be an issue if you were using a non-ps1 ref cat.
            Hide
            lauren Lauren MacArthur added a comment - - edited

            Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)

            Show
            lauren Lauren MacArthur added a comment - - edited Tim, the code looks fine to me. If you can confirm the fix works, feel free to merge. (And note that your branch is well behind master at this point, so you will need to rebase.)
            lauren Lauren MacArthur made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            tmorton Tim Morton added a comment -

            Yeah, looking to try to confirm now.

            Show
            tmorton Tim Morton added a comment - Yeah, looking to try to confirm now.
            Hide
            tmorton Tim Morton added a comment -

            OK, I see that based on the changes Paul Price has made to the config file (https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699) this bug is no longer relevant.

            Show
            tmorton Tim Morton added a comment - OK, I see that based on the changes Paul Price has made to the config file ( https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699 ) this bug is no longer relevant.
            tmorton Tim Morton made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Won't Fix [ 10405 ]
            tmorton Tim Morton made changes -
            Comment [ This bug was from a previous version of the config file before dependence on astrometry_net was removed by (https://github.com/lsst/obs_subaru/commit/384c5e33ff039f1953261cd03d86ec5a7677c699) ]

              People

              • Assignee:
                tmorton Tim Morton
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Lauren MacArthur
                Watchers:
                John Parejko, John Swinbank, Lauren MacArthur, Paul Price, Simon Krughoff, Tim Morton
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel