Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9502

SpherePoint throws wrong exception for invalid arguments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Description

      Several methods in SpherePoint throw pex::exceptions::OutOfRangeError when fed invalid arguments. Assuming the pex exceptions are intended to mimic the standard C++ exceptions of the same name (see DM-9435), this is inappropriate – OutOfRangeError should refer to invalid indices, not other cases where an argument falls outside some interval.

      These methods should be changed to throw either pex::exceptions::DomainError or pex::exceptions::InvalidParameterError, which apply to generic numerical arguments.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            That said, this is yet another example of DM-9435...

            Yes, that's why I assigned it to you. Merged with my thanks.

            Show
            krzys Krzysztof Findeisen added a comment - That said, this is yet another example of DM-9435 ... Yes, that's why I assigned it to you. Merged with my thanks.
            Hide
            Parejkoj John Parejko added a comment -

            Looks good to me. I only reviewed the change relevant to this ticket: I'm not sure how to even go about reviewing the clang-format and doxygen changes.

            That said, this is yet another example of DM-9435...

            Show
            Parejkoj John Parejko added a comment - Looks good to me. I only reviewed the change relevant to this ticket: I'm not sure how to even go about reviewing the clang-format and doxygen changes. That said, this is yet another example of DM-9435 ...
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi, please review this fix to SpherePoint's exception spec.

            Show
            krzys Krzysztof Findeisen added a comment - Hi, please review this fix to SpherePoint's exception spec.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.