Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9519

Fix order-of-arguments to SingleFrameMeasurementTask.run() in meas_extensions_ngmix

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_extensions_ngmix
    • Labels:
      None

      Description

      Following DM-3804, the meas_extensions_ngmix tests fail with:

      Traceback (most recent call last):
      		 
        File "tests/testLMSimpleShape.py", line 130, in testMaxFev
      		 
          source, msf = self.runShape(config, self.algName, self.exposure, model='dev')
      		 
        File "tests/testLMSimpleShape.py", line 103, in runShape
      		 
          task.run(exposure, cat)
      		 
        File "/ssd/swinbank/lsstsw-py2/stack/Linux64/meas_base/12.1-11-g06625e2/python/lsst/meas/base/sfm.py", line 287, in run
      		 
          assert measCat.getSchema().contains(self.schema)
      		 
        File "/ssd/swinbank/lsstsw-py2/stack/Linux64/afw/12.1-33-g072fda8/python/lsst/afw/image/imageLib.py", line 11600, in <lambda>
      		 
          __getattr__ = lambda self, name: _swig_getattr(self, ExposureF, name)
      		 
        File "/ssd/swinbank/lsstsw-py2/stack/Linux64/afw/12.1-33-g072fda8/python/lsst/afw/image/imageLib.py", line 89, in _swig_getattr
      		 
          raise AttributeError("'%s' object has no attribute '%s'" % (class_type.__name__, name))
      		 
      AttributeError: 'ExposureF' object has no attribute 'getSchema'

      And similar. Should be a simple order-of-arguments fix.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9504 lsst_py3 CI failure due to meas_extensions_ngmix

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Hey Lauren, can I bother you for this super-trivial review, please?

            Show
            swinbank John Swinbank added a comment - Hey Lauren, can I bother you for this super-trivial review, please?
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Commit message could indicate that the "task" in question is SFM.

            Good to go.

            Show
            lauren Lauren MacArthur added a comment - Commit message could indicate that the "task" in question is SFM. Good to go.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Tweaked commit message and merged. Thank you!

            Show
            swinbank John Swinbank added a comment - Tweaked commit message and merged. Thank you!

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Lauren MacArthur
              Watchers:
              John Swinbank, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.