Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-9520

Remove calibrateTask.py example from Stack (for now)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      This is triggered by RFC-290, and will be comprised of 2 parts: actually removing calibrateTask from the current pipetasks examples dir, and then editing the doxygen docs so that the example is not referred to any further on the doxygen pages.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-290 Remove runIsrTask.py and calibrateTask.py examples from Stack? (for now)

          • Implemented
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-9142 calibrateTask.py example not working on current stack

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mssgill Mandeep Gill [X] (Inactive) added a comment -

            Hi Tim- could you take a quick look and review this parallel one, also? Have removed this example and the docstrings in the actual calibrate.py and charImg here, too. Thx! -M

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - Hi Tim- could you take a quick look and review this parallel one, also? Have removed this example and the docstrings in the actual calibrate.py and charImg here, too. Thx! -M
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This looks reasonable. Did you do a test build to make sure nothing weird has gone wrong with it?

            Show
            tjenness Tim Jenness added a comment - This looks reasonable. Did you do a test build to make sure nothing weird has gone wrong with it?
            Hide
            Permalink
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited

            Very reasonable q, and yes, i did a test build of the docs dir, and it checks out – the page for charImg and calib now both go straight from the Debug section to the description of the Constructor with the Example section cleanly excised, and looks just fine.

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited Very reasonable q, and yes, i did a test build of the docs dir, and it checks out – the page for charImg and calib now both go straight from the Debug section to the description of the Constructor with the Example section cleanly excised, and looks just fine.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Given that this PR was merged and that RFC-290 was closed, can you please also close this ticket?

            Show
            tjenness Tim Jenness added a comment - Given that this PR was merged and that RFC-290 was closed, can you please also close this ticket?
            Hide
            Permalink
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited

            Yep, thx for the reminder Tim Jenness – removal completed.

            Show
            mssgill Mandeep Gill [X] (Inactive) added a comment - - edited Yep, thx for the reminder Tim Jenness – removal completed.

              People

              Assignee:
              mssgill Mandeep Gill [X] (Inactive)
              Reporter:
              mssgill Mandeep Gill [X] (Inactive)
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Mandeep Gill [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.